From aa788891d401fed0862b4288786c98a2c8b797ca Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 9 Mar 2022 15:33:25 -0800 Subject: [PATCH 1/5] [flutter_lints] version 2.0 --- packages/flutter_lints/CHANGELOG.md | 19 +++++++++++++++++++ packages/flutter_lints/lib/flutter.yaml | 2 ++ packages/flutter_lints/pubspec.yaml | 4 ++-- 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/packages/flutter_lints/CHANGELOG.md b/packages/flutter_lints/CHANGELOG.md index 2d31e2028b3..4537285361c 100644 --- a/packages/flutter_lints/CHANGELOG.md +++ b/packages/flutter_lints/CHANGELOG.md @@ -1,3 +1,22 @@ +## 2.0.0 + +* Added the following lints: + * `sort_child_properties_last` + * `use_build_context_synchronously` +* Updated `package:lints` dependency to version 2.0.0, which added the following lints: + * `depend_on_referenced_packages` + * `null_check_on_nullable_type_parameter` + * `library_private_types_in_public_api` + * `no_leading_underscores_for_library_prefixes` + * `no_leading_underscores_for_local_identifiers` + * `null_check_on_nullable_type_parameter` + * `prefer_interpolation_to_compose_strings` + * `unnecessary_constructor_name` + * `unnecessary_late` + * `unnecessary_null_aware_assignments` + * `unnecessary_nullable_for_final_variable_declarations` +* Bumped the minimum required Dart SDK version to 2.17 + ## 1.0.4 * Small update to readme diff --git a/packages/flutter_lints/lib/flutter.yaml b/packages/flutter_lints/lib/flutter.yaml index 05276da1f2c..bcad70fc108 100644 --- a/packages/flutter_lints/lib/flutter.yaml +++ b/packages/flutter_lints/lib/flutter.yaml @@ -13,5 +13,7 @@ linter: - prefer_const_declarations - prefer_const_literals_to_create_immutables - sized_box_for_whitespace + - sort_child_properties_last + - use_build_context_synchronously - use_full_hex_values_for_flutter_colors - use_key_in_widget_constructors diff --git a/packages/flutter_lints/pubspec.yaml b/packages/flutter_lints/pubspec.yaml index 35fb2385e32..0fcd7933d92 100644 --- a/packages/flutter_lints/pubspec.yaml +++ b/packages/flutter_lints/pubspec.yaml @@ -5,8 +5,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+ version: 1.0.4 environment: - sdk: '>=2.12.0 <3.0.0' + sdk: '>=2.17.0-0 <3.0.0' dependencies: - lints: ^1.0.0 + lints: ^2.0.0 # Code is not allowed in this package. Do not add any dependencies or dev_dependencies. From 54f95598ad71e778d0e385943971ac2b2bc7bad6 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 9 Mar 2022 16:19:10 -0800 Subject: [PATCH 2/5] alphabetize --- packages/flutter_lints/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/flutter_lints/CHANGELOG.md b/packages/flutter_lints/CHANGELOG.md index 4537285361c..1eaf6e67efa 100644 --- a/packages/flutter_lints/CHANGELOG.md +++ b/packages/flutter_lints/CHANGELOG.md @@ -5,11 +5,11 @@ * `use_build_context_synchronously` * Updated `package:lints` dependency to version 2.0.0, which added the following lints: * `depend_on_referenced_packages` - * `null_check_on_nullable_type_parameter` * `library_private_types_in_public_api` * `no_leading_underscores_for_library_prefixes` * `no_leading_underscores_for_local_identifiers` * `null_check_on_nullable_type_parameter` + * `null_check_on_nullable_type_parameter` * `prefer_interpolation_to_compose_strings` * `unnecessary_constructor_name` * `unnecessary_late` From 05869c1b50a50ff27625348818a95d99426cff8d Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 9 Mar 2022 16:26:21 -0800 Subject: [PATCH 3/5] remove duplicate --- packages/flutter_lints/CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/flutter_lints/CHANGELOG.md b/packages/flutter_lints/CHANGELOG.md index 1eaf6e67efa..d0613c534a9 100644 --- a/packages/flutter_lints/CHANGELOG.md +++ b/packages/flutter_lints/CHANGELOG.md @@ -9,7 +9,6 @@ * `no_leading_underscores_for_library_prefixes` * `no_leading_underscores_for_local_identifiers` * `null_check_on_nullable_type_parameter` - * `null_check_on_nullable_type_parameter` * `prefer_interpolation_to_compose_strings` * `unnecessary_constructor_name` * `unnecessary_late` From 0b7c295eb31b9f95ae359e1a801185372f60b62c Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 17 Mar 2022 14:33:22 -0700 Subject: [PATCH 4/5] fix pubspec --- packages/flutter_lints/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/flutter_lints/pubspec.yaml b/packages/flutter_lints/pubspec.yaml index 0fcd7933d92..35a2aea8678 100644 --- a/packages/flutter_lints/pubspec.yaml +++ b/packages/flutter_lints/pubspec.yaml @@ -2,7 +2,7 @@ name: flutter_lints description: Recommended lints for Flutter apps, packages, and plugins to encourage good coding practices. repository: https://github.com/flutter/packages/tree/main/packages/flutter_lints issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_lints%22 -version: 1.0.4 +version: 2.0.0 environment: sdk: '>=2.17.0-0 <3.0.0' From cce384d38c491bc9c15595564bd7acfe80033e20 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Fri, 18 Mar 2022 10:20:14 -0700 Subject: [PATCH 5/5] add --allow-pre-release --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index f0787fed7db..11c0e8ebcb0 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -76,7 +76,7 @@ task: - echo "$CIRRUS_CHANGE_MESSAGE" > "$CHANGE_DESC" - ./script/tool_runner.sh version-check --check-for-missing-changes --change-description-file="$CHANGE_DESC" - fi - publishable_script: ./script/tool_runner.sh publish-check + publishable_script: ./script/tool_runner.sh publish-check --allow-pre-release depends_on: - format+analyze - name: test