Skip to content

[file_selector_web] feat: Support XFile.mimeType#11703

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Gustl22:93379-file_selector_web-mimetype
Jun 1, 2026
Merged

[file_selector_web] feat: Support XFile.mimeType#11703
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Gustl22:93379-file_selector_web-mimetype

Conversation

@Gustl22

@Gustl22 Gustl22 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Support providing mime type to XFile blob on Web file_selector.

This is useful (as in other contexts of web) to provide the mimeType to e.g. a media player to support blob urls.

Related: flutter/flutter#93379

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for mimeType to XFile in the file_selector_web package. The changes include updating the _convertFileToXFile method to extract the MIME type from the web File object and enhancing integration tests to verify this property. The package version is bumped to 0.9.5. I have no feedback to provide as there were no review comments.

@stuartmorgan-g stuartmorgan-g requested a review from mdebbar May 19, 2026 18:21
@stuartmorgan-g stuartmorgan-g added the triage-web Should be looked at in web triage label May 19, 2026
@stuartmorgan-g stuartmorgan-g self-requested a review May 19, 2026 18:21

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label May 20, 2026
@flutter-dashboard

Copy link
Copy Markdown

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

…_web-mimetype

# Conflicts:
#	packages/file_selector/file_selector_web/CHANGELOG.md
@github-actions github-actions Bot removed the CICD Run CI/CD label May 22, 2026
@mdebbar mdebbar added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 1, 2026
@auto-submit auto-submit Bot merged commit 818b310 into flutter:main Jun 1, 2026
86 checks passed
pull Bot pushed a commit to jinzaizhichi/flutter that referenced this pull request Jun 3, 2026
…r#187441)

flutter/packages@f5d50ca...818b310

2026-06-01 git@reb0.org [file_selector_web] feat: Support XFile.mimeType
(flutter/packages#11703)
2026-06-01 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
559ffa3 to 924134a (4 revisions) (flutter/packages#11817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: file_selector platform-web triage-web Should be looked at in web triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants