From 18b2165d65daf90316a3885bd54374c90f1070b7 Mon Sep 17 00:00:00 2001 From: GP4cK Date: Fri, 14 Apr 2023 08:35:03 +0800 Subject: [PATCH 1/2] Remove unused navigator keys --- packages/go_router/lib/src/route_data.dart | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/go_router/lib/src/route_data.dart b/packages/go_router/lib/src/route_data.dart index 3530ca250fc..36c0f22c132 100644 --- a/packages/go_router/lib/src/route_data.dart +++ b/packages/go_router/lib/src/route_data.dart @@ -119,11 +119,6 @@ abstract class GoRouteData extends RouteData { static final Expando _stateObjectExpando = Expando( 'GoRouteState to GoRouteData expando', ); - - /// [navigatorKey] is used to point to a certain navigator - /// - /// It will use the given key to find the right navigator for [GoRoute] - GlobalKey? get navigatorKey => null; } /// Base class for supporting @@ -206,9 +201,6 @@ abstract class ShellRouteData extends RouteData { Expando( 'GoRouteState to ShellRouteData expando', ); - - /// It will be used to instantiate [Navigator] with the given key - GlobalKey? get navigatorKey => null; } /// A superclass for each typed route descendant From 5746f83393e4d45db9e6cc9d19721f9e43f81a2e Mon Sep 17 00:00:00 2001 From: GP4cK Date: Fri, 14 Apr 2023 08:38:42 +0800 Subject: [PATCH 2/2] Update version and changelog --- packages/go_router/CHANGELOG.md | 6 +++++- packages/go_router/pubspec.yaml | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index df331c32997..19520fe79a2 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,3 +1,7 @@ +## 6.5.7 + +- Removes navigator keys from `GoRouteData` and `ShellRouteData`. + ## 6.5.6 - Fixes an issue where ShellRoute routes were not logged when debugLogDiagnostic was enabled. @@ -8,7 +12,7 @@ ## 6.5.4 -- Remove navigator keys from `TypedGoRoute` and `TypedShellRoute`. +- Removes navigator keys from `TypedGoRoute` and `TypedShellRoute`. ## 6.5.3 diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index 5c08a6a13c8..1bd627951aa 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 6.5.6 +version: 6.5.7 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22