diff --git a/analysis_options.yaml b/analysis_options.yaml index c4fe4824ac8a..0e07b3324b81 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -81,7 +81,7 @@ linter: # - avoid_multiple_declarations_per_line # seems to be a stylistic choice we don't subscribe to - avoid_null_checks_in_equality_operators # - avoid_positional_boolean_parameters # would have been nice to enable this but by now there's too many places that break it - # - avoid_print # LOCAL CHANGE - Needs to be enabled and violations fixed. + - avoid_print # - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356) - avoid_redundant_argument_values - avoid_relative_lib_imports @@ -204,7 +204,7 @@ linter: - recursive_getters # - require_trailing_commas # blocked on https://github.com/dart-lang/sdk/issues/47441 - secure_pubspec_urls - - sized_box_for_whitespace + - sized_box_for_whitespace # - sized_box_shrink_expand # not yet tested - slash_for_doc_comments - sort_child_properties_last diff --git a/packages/camera/camera/CHANGELOG.md b/packages/camera/camera/CHANGELOG.md index 127da4561bc3..f5d87a60eed7 100644 --- a/packages/camera/camera/CHANGELOG.md +++ b/packages/camera/camera/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.10.0+5 + +* Updates code for stricter lint checks. + ## 0.10.0+4 * Removes usage of `_ambiguate` method in example. diff --git a/packages/camera/camera/README.md b/packages/camera/camera/README.md index 4d7c3d90791a..86b0355b8bcc 100644 --- a/packages/camera/camera/README.md +++ b/packages/camera/camera/README.md @@ -141,10 +141,10 @@ class _CameraAppState extends State { if (e is CameraException) { switch (e.code) { case 'CameraAccessDenied': - print('User denied camera access.'); + // Handle access errors here. break; default: - print('Handle other errors.'); + // Handle other errors here. break; } } diff --git a/packages/camera/camera/example/integration_test/camera_test.dart b/packages/camera/camera/example/integration_test/camera_test.dart index b233d4958c8a..f0cc67f0c06c 100644 --- a/packages/camera/camera/example/integration_test/camera_test.dart +++ b/packages/camera/camera/example/integration_test/camera_test.dart @@ -55,8 +55,6 @@ void main() { Future testCaptureImageResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Picture final XFile file = await controller.takePicture(); @@ -104,8 +102,6 @@ void main() { Future testCaptureVideoResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Video await controller.startVideoRecording(); diff --git a/packages/camera/camera/example/lib/main.dart b/packages/camera/camera/example/lib/main.dart index 860263edf2d3..4911625ae08e 100644 --- a/packages/camera/camera/example/lib/main.dart +++ b/packages/camera/camera/example/lib/main.dart @@ -37,11 +37,8 @@ IconData getCameraLensIcon(CameraLensDirection direction) { } void _logError(String code, String? message) { - if (message != null) { - print('Error: $code\nError Message: $message'); - } else { - print('Error: $code'); - } + // ignore: avoid_print + print('Error: $code${message == null ? '' : '\nError Message: $message'}'); } class _CameraExampleHomeState extends State diff --git a/packages/camera/camera/example/lib/readme_full_example.dart b/packages/camera/camera/example/lib/readme_full_example.dart index a3c232ec44f7..20bfe78c30fc 100644 --- a/packages/camera/camera/example/lib/readme_full_example.dart +++ b/packages/camera/camera/example/lib/readme_full_example.dart @@ -40,10 +40,10 @@ class _CameraAppState extends State { if (e is CameraException) { switch (e.code) { case 'CameraAccessDenied': - print('User denied camera access.'); + // Handle access errors here. break; default: - print('Handle other errors.'); + // Handle other errors here. break; } } diff --git a/packages/camera/camera/example/test_driver/integration_test.dart b/packages/camera/camera/example/test_driver/integration_test.dart index 4ec97e66d36c..aa57599f3165 100644 --- a/packages/camera/camera/example/test_driver/integration_test.dart +++ b/packages/camera/camera/example/test_driver/integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'dart:async'; import 'dart:convert'; import 'dart:io'; diff --git a/packages/camera/camera/pubspec.yaml b/packages/camera/camera/pubspec.yaml index 0f75d10c36cd..a867a5ae8896 100644 --- a/packages/camera/camera/pubspec.yaml +++ b/packages/camera/camera/pubspec.yaml @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing Dart. repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.10.0+4 +version: 0.10.0+5 environment: sdk: ">=2.14.0 <3.0.0" diff --git a/packages/camera/camera_android/example/integration_test/camera_test.dart b/packages/camera/camera_android/example/integration_test/camera_test.dart index 0ddb66388456..e499872da5f3 100644 --- a/packages/camera/camera_android/example/integration_test/camera_test.dart +++ b/packages/camera/camera_android/example/integration_test/camera_test.dart @@ -55,8 +55,6 @@ void main() { Future testCaptureImageResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Picture final XFile file = await controller.takePicture(); @@ -105,8 +103,6 @@ void main() { Future testCaptureVideoResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Video await controller.startVideoRecording(); diff --git a/packages/camera/camera_android/example/lib/main.dart b/packages/camera/camera_android/example/lib/main.dart index 9ebc27e4be5b..af9aab1a8a86 100644 --- a/packages/camera/camera_android/example/lib/main.dart +++ b/packages/camera/camera_android/example/lib/main.dart @@ -41,11 +41,8 @@ IconData getCameraLensIcon(CameraLensDirection direction) { } void _logError(String code, String? message) { - if (message != null) { - print('Error: $code\nError Message: $message'); - } else { - print('Error: $code'); - } + // ignore: avoid_print + print('Error: $code${message == null ? '' : '\nError Message: $message'}'); } class _CameraExampleHomeState extends State diff --git a/packages/camera/camera_android/example/test_driver/integration_test.dart b/packages/camera/camera_android/example/test_driver/integration_test.dart index 4ec97e66d36c..aa57599f3165 100644 --- a/packages/camera/camera_android/example/test_driver/integration_test.dart +++ b/packages/camera/camera_android/example/test_driver/integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'dart:async'; import 'dart:convert'; import 'dart:io'; diff --git a/packages/camera/camera_avfoundation/example/integration_test/camera_test.dart b/packages/camera/camera_avfoundation/example/integration_test/camera_test.dart index 2b23d82e619f..34d460d44ec7 100644 --- a/packages/camera/camera_avfoundation/example/integration_test/camera_test.dart +++ b/packages/camera/camera_avfoundation/example/integration_test/camera_test.dart @@ -56,8 +56,6 @@ void main() { Future testCaptureImageResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Picture final XFile file = await controller.takePicture(); @@ -102,8 +100,6 @@ void main() { Future testCaptureVideoResolution( CameraController controller, ResolutionPreset preset) async { final Size expectedSize = presetExpectedSizes[preset]!; - print( - 'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}'); // Take Video await controller.startVideoRecording(); diff --git a/packages/camera/camera_avfoundation/example/lib/main.dart b/packages/camera/camera_avfoundation/example/lib/main.dart index 9ebc27e4be5b..af9aab1a8a86 100644 --- a/packages/camera/camera_avfoundation/example/lib/main.dart +++ b/packages/camera/camera_avfoundation/example/lib/main.dart @@ -41,11 +41,8 @@ IconData getCameraLensIcon(CameraLensDirection direction) { } void _logError(String code, String? message) { - if (message != null) { - print('Error: $code\nError Message: $message'); - } else { - print('Error: $code'); - } + // ignore: avoid_print + print('Error: $code${message == null ? '' : '\nError Message: $message'}'); } class _CameraExampleHomeState extends State diff --git a/packages/camera/camera_web/test/more_tests_exist_elsewhere_test.dart b/packages/camera/camera_web/test/more_tests_exist_elsewhere_test.dart index dc2b64c111d7..32f037effdf1 100644 --- a/packages/camera/camera_web/test/more_tests_exist_elsewhere_test.dart +++ b/packages/camera/camera_web/test/more_tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/file_selector/file_selector/example/lib/save_text_page.dart b/packages/file_selector/file_selector/example/lib/save_text_page.dart index 6dc765f7accf..0a49e6f0382c 100644 --- a/packages/file_selector/file_selector/example/lib/save_text_page.dart +++ b/packages/file_selector/file_selector/example/lib/save_text_page.dart @@ -56,7 +56,7 @@ class SaveTextPage extends StatelessWidget { child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ - Container( + SizedBox( width: 300, child: TextField( minLines: 1, @@ -67,7 +67,7 @@ class SaveTextPage extends StatelessWidget { ), ), ), - Container( + SizedBox( width: 300, child: TextField( minLines: 1, diff --git a/packages/file_selector/file_selector_linux/example/lib/save_text_page.dart b/packages/file_selector/file_selector_linux/example/lib/save_text_page.dart index 9803f285a536..aca041f474c7 100644 --- a/packages/file_selector/file_selector_linux/example/lib/save_text_page.dart +++ b/packages/file_selector/file_selector_linux/example/lib/save_text_page.dart @@ -42,7 +42,7 @@ class SaveTextPage extends StatelessWidget { child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ - Container( + SizedBox( width: 300, child: TextField( minLines: 1, @@ -53,7 +53,7 @@ class SaveTextPage extends StatelessWidget { ), ), ), - Container( + SizedBox( width: 300, child: TextField( minLines: 1, diff --git a/packages/file_selector/file_selector_macos/example/lib/save_text_page.dart b/packages/file_selector/file_selector_macos/example/lib/save_text_page.dart index 3f215fea0a23..f80aeadbed09 100644 --- a/packages/file_selector/file_selector_macos/example/lib/save_text_page.dart +++ b/packages/file_selector/file_selector_macos/example/lib/save_text_page.dart @@ -42,7 +42,7 @@ class SaveTextPage extends StatelessWidget { child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ - Container( + SizedBox( width: 300, child: TextField( minLines: 1, @@ -53,7 +53,7 @@ class SaveTextPage extends StatelessWidget { ), ), ), - Container( + SizedBox( width: 300, child: TextField( minLines: 1, diff --git a/packages/file_selector/file_selector_web/test/more_tests_exist_elsewhere_test.dart b/packages/file_selector/file_selector_web/test/more_tests_exist_elsewhere_test.dart index 37c6eb644c9b..2fef89bb48df 100644 --- a/packages/file_selector/file_selector_web/test/more_tests_exist_elsewhere_test.dart +++ b/packages/file_selector/file_selector_web/test/more_tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/file_selector/file_selector_windows/example/lib/save_text_page.dart b/packages/file_selector/file_selector_windows/example/lib/save_text_page.dart index 9803f285a536..aca041f474c7 100644 --- a/packages/file_selector/file_selector_windows/example/lib/save_text_page.dart +++ b/packages/file_selector/file_selector_windows/example/lib/save_text_page.dart @@ -42,7 +42,7 @@ class SaveTextPage extends StatelessWidget { child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ - Container( + SizedBox( width: 300, child: TextField( minLines: 1, @@ -53,7 +53,7 @@ class SaveTextPage extends StatelessWidget { ), ), ), - Container( + SizedBox( width: 300, child: TextField( minLines: 1, diff --git a/packages/google_maps_flutter/google_maps_flutter/example/lib/map_coordinates.dart b/packages/google_maps_flutter/google_maps_flutter/example/lib/map_coordinates.dart index 12e31be8f7c7..efb4a105fd0f 100644 --- a/packages/google_maps_flutter/google_maps_flutter/example/lib/map_coordinates.dart +++ b/packages/google_maps_flutter/google_maps_flutter/example/lib/map_coordinates.dart @@ -72,7 +72,7 @@ class _MapCoordinatesBodyState extends State<_MapCoordinatesBody> { // Add a block at the bottom of this list to allow validation that the visible region of the map // does not change when scrolled under the safe view on iOS. // https://github.com/flutter/flutter/issues/107913 - Container( + const SizedBox( width: 300, height: 1000, ), diff --git a/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart b/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart index 6d650661c5e7..c6e71137903b 100644 --- a/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart @@ -180,8 +180,7 @@ void main() { testWidgets('Update non platform related attr', (WidgetTester tester) async { Circle c1 = const Circle(circleId: CircleId('circle_1')); final Set prev = {c1}; - c1 = Circle( - circleId: const CircleId('circle_1'), onTap: () => print('hello')); + c1 = Circle(circleId: const CircleId('circle_1'), onTap: () {}); final Set cur = {c1}; await tester.pumpWidget(_mapWithCircles(prev)); diff --git a/packages/google_maps_flutter/google_maps_flutter/test/marker_updates_test.dart b/packages/google_maps_flutter/google_maps_flutter/test/marker_updates_test.dart index b5bba55671c8..0acde97e8d9a 100644 --- a/packages/google_maps_flutter/google_maps_flutter/test/marker_updates_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter/test/marker_updates_test.dart @@ -185,8 +185,8 @@ void main() { final Set prev = {m1}; m1 = Marker( markerId: const MarkerId('marker_1'), - onTap: () => print('hello'), - onDragEnd: (LatLng latLng) => print(latLng)); + onTap: () {}, + onDragEnd: (LatLng latLng) {}); final Set cur = {m1}; await tester.pumpWidget(_mapWithMarkers(prev)); diff --git a/packages/google_maps_flutter/google_maps_flutter/test/polygon_updates_test.dart b/packages/google_maps_flutter/google_maps_flutter/test/polygon_updates_test.dart index 34959832b36b..1e5ea84a0422 100644 --- a/packages/google_maps_flutter/google_maps_flutter/test/polygon_updates_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter/test/polygon_updates_test.dart @@ -208,8 +208,7 @@ void main() { testWidgets('Update non platform related attr', (WidgetTester tester) async { Polygon p1 = const Polygon(polygonId: PolygonId('polygon_1')); final Set prev = {p1}; - p1 = Polygon( - polygonId: const PolygonId('polygon_1'), onTap: () => print(2 + 2)); + p1 = Polygon(polygonId: const PolygonId('polygon_1'), onTap: () {}); final Set cur = {p1}; await tester.pumpWidget(_mapWithPolygons(prev)); diff --git a/packages/google_maps_flutter/google_maps_flutter/test/polyline_updates_test.dart b/packages/google_maps_flutter/google_maps_flutter/test/polyline_updates_test.dart index f9d091695383..4c68a71542d5 100644 --- a/packages/google_maps_flutter/google_maps_flutter/test/polyline_updates_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter/test/polyline_updates_test.dart @@ -202,8 +202,7 @@ void main() { testWidgets('Update non platform related attr', (WidgetTester tester) async { Polyline p1 = const Polyline(polylineId: PolylineId('polyline_1')); final Set prev = {p1}; - p1 = Polyline( - polylineId: const PolylineId('polyline_1'), onTap: () => print(2 + 2)); + p1 = Polyline(polylineId: const PolylineId('polyline_1'), onTap: () {}); final Set cur = {p1}; await tester.pumpWidget(_mapWithPolylines(prev)); diff --git a/packages/google_maps_flutter/google_maps_flutter_android/example/lib/map_coordinates.dart b/packages/google_maps_flutter/google_maps_flutter_android/example/lib/map_coordinates.dart index 185a97e08f00..22f383bd1254 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/example/lib/map_coordinates.dart +++ b/packages/google_maps_flutter/google_maps_flutter_android/example/lib/map_coordinates.dart @@ -74,7 +74,7 @@ class _MapCoordinatesBodyState extends State<_MapCoordinatesBody> { // Add a block at the bottom of this list to allow validation that the visible region of the map // does not change when scrolled under the safe view on iOS. // https://github.com/flutter/flutter/issues/107913 - Container( + const SizedBox( width: 300, height: 1000, ), diff --git a/packages/google_maps_flutter/google_maps_flutter_ios/example/lib/map_coordinates.dart b/packages/google_maps_flutter/google_maps_flutter_ios/example/lib/map_coordinates.dart index 185a97e08f00..22f383bd1254 100644 --- a/packages/google_maps_flutter/google_maps_flutter_ios/example/lib/map_coordinates.dart +++ b/packages/google_maps_flutter/google_maps_flutter_ios/example/lib/map_coordinates.dart @@ -74,7 +74,7 @@ class _MapCoordinatesBodyState extends State<_MapCoordinatesBody> { // Add a block at the bottom of this list to allow validation that the visible region of the map // does not change when scrolled under the safe view on iOS. // https://github.com/flutter/flutter/issues/107913 - Container( + const SizedBox( width: 300, height: 1000, ), diff --git a/packages/google_maps_flutter/google_maps_flutter_web/test/tests_exist_elsewhere_test.dart b/packages/google_maps_flutter/google_maps_flutter_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/google_maps_flutter/google_maps_flutter_web/test/tests_exist_elsewhere_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/google_sign_in/google_sign_in/example/lib/main.dart b/packages/google_sign_in/google_sign_in/example/lib/main.dart index 4c27543f5b18..889993b448f1 100644 --- a/packages/google_sign_in/google_sign_in/example/lib/main.dart +++ b/packages/google_sign_in/google_sign_in/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert' show json; diff --git a/packages/google_sign_in/google_sign_in_android/example/lib/main.dart b/packages/google_sign_in/google_sign_in_android/example/lib/main.dart index 5818b6040fcc..90d7da831ef8 100644 --- a/packages/google_sign_in/google_sign_in_android/example/lib/main.dart +++ b/packages/google_sign_in/google_sign_in_android/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert' show json; diff --git a/packages/google_sign_in/google_sign_in_ios/example/lib/main.dart b/packages/google_sign_in/google_sign_in_ios/example/lib/main.dart index e23935ded1da..33deb3d388c8 100644 --- a/packages/google_sign_in/google_sign_in_ios/example/lib/main.dart +++ b/packages/google_sign_in/google_sign_in_ios/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert' show json; diff --git a/packages/google_sign_in/google_sign_in_web/test/tests_exist_elsewhere_test.dart b/packages/google_sign_in/google_sign_in_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/google_sign_in/google_sign_in_web/test/tests_exist_elsewhere_test.dart +++ b/packages/google_sign_in/google_sign_in_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/image_picker/image_picker_for_web/test/tests_exist_elsewhere_test.dart b/packages/image_picker/image_picker_for_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/image_picker/image_picker_for_web/test/tests_exist_elsewhere_test.dart +++ b/packages/image_picker/image_picker_for_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart b/packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart index 4eea725b089f..cc612d1918b6 100644 --- a/packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart +++ b/packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'dart:async'; import 'package:flutter/material.dart'; diff --git a/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform_addition.dart b/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform_addition.dart index 070c138b32e6..b467b89b68a9 100644 --- a/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform_addition.dart +++ b/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform_addition.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:in_app_purchase_platform_interface/in_app_purchase_platform_interface.dart'; import '../in_app_purchase_storekit.dart'; diff --git a/packages/ios_platform_images/example/lib/main.dart b/packages/ios_platform_images/example/lib/main.dart index 929814ecce00..043bc69c944d 100644 --- a/packages/ios_platform_images/example/lib/main.dart +++ b/packages/ios_platform_images/example/lib/main.dart @@ -22,6 +22,7 @@ class _MyAppState extends State { super.initState(); IosPlatformImages.resolveURL('textfile') + // ignore: avoid_print .then((String? value) => print(value)); } diff --git a/packages/local_auth/local_auth/example/lib/main.dart b/packages/local_auth/local_auth/example/lib/main.dart index 1330012421ca..f2cded002084 100644 --- a/packages/local_auth/local_auth/example/lib/main.dart +++ b/packages/local_auth/local_auth/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; diff --git a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart index 340aaef28f84..ccccf5c50ae9 100644 --- a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart +++ b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart @@ -5,7 +5,7 @@ // This file exists solely to host compiled excerpts for README.md, and is not // intended for use as an actual example application. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'package:flutter/material.dart'; // #docregion ErrorHandling diff --git a/packages/local_auth/local_auth_android/example/lib/main.dart b/packages/local_auth/local_auth_android/example/lib/main.dart index 9909853a62af..f7d908c81973 100644 --- a/packages/local_auth/local_auth_android/example/lib/main.dart +++ b/packages/local_auth/local_auth_android/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; diff --git a/packages/local_auth/local_auth_ios/example/lib/main.dart b/packages/local_auth/local_auth_ios/example/lib/main.dart index fdbf11ffbcaa..3aa8d6625232 100644 --- a/packages/local_auth/local_auth_ios/example/lib/main.dart +++ b/packages/local_auth/local_auth_ios/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; diff --git a/packages/local_auth/local_auth_windows/example/lib/main.dart b/packages/local_auth/local_auth_windows/example/lib/main.dart index c7b3fd923891..546b635b8eca 100644 --- a/packages/local_auth/local_auth_windows/example/lib/main.dart +++ b/packages/local_auth/local_auth_windows/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; diff --git a/packages/path_provider/path_provider_linux/example/lib/main.dart b/packages/path_provider/path_provider_linux/example/lib/main.dart index 1c7c7e87397a..d7201468f6c1 100644 --- a/packages/path_provider/path_provider_linux/example/lib/main.dart +++ b/packages/path_provider/path_provider_linux/example/lib/main.dart @@ -41,29 +41,25 @@ class _MyAppState extends State { // Platform messages may fail, so we use a try/catch PlatformException. try { tempDirectory = await _provider.getTemporaryPath(); - } on PlatformException catch (e, stackTrace) { + } on PlatformException { tempDirectory = 'Failed to get temp directory.'; - print('$tempDirectory $e $stackTrace'); } try { downloadsDirectory = await _provider.getDownloadsPath(); - } on PlatformException catch (e, stackTrace) { + } on PlatformException { downloadsDirectory = 'Failed to get downloads directory.'; - print('$downloadsDirectory $e $stackTrace'); } try { documentsDirectory = await _provider.getApplicationDocumentsPath(); - } on PlatformException catch (e, stackTrace) { + } on PlatformException { documentsDirectory = 'Failed to get documents directory.'; - print('$documentsDirectory $e $stackTrace'); } try { appSupportDirectory = await _provider.getApplicationSupportPath(); - } on PlatformException catch (e, stackTrace) { + } on PlatformException { appSupportDirectory = 'Failed to get documents directory.'; - print('$appSupportDirectory $e $stackTrace'); } // If the widget was removed from the tree while the asynchronous platform // message was in flight, we want to discard the reply rather than calling diff --git a/packages/shared_preferences/shared_preferences_linux/CHANGELOG.md b/packages/shared_preferences/shared_preferences_linux/CHANGELOG.md index 5d59660b4d6b..7c518fcf71cb 100644 --- a/packages/shared_preferences/shared_preferences_linux/CHANGELOG.md +++ b/packages/shared_preferences/shared_preferences_linux/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 2.1.2 +* Updates code for stricter lint checks. * Updates code for `no_leading_underscores_for_local_identifiers` lint. * Updates minimum Flutter version to 2.10. diff --git a/packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart b/packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart index b6a9a5bca4ff..1cc1c41f871b 100644 --- a/packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart +++ b/packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart @@ -7,7 +7,7 @@ import 'dart:convert' show json; import 'package:file/file.dart'; import 'package:file/local.dart'; -import 'package:flutter/foundation.dart' show visibleForTesting; +import 'package:flutter/foundation.dart' show debugPrint, visibleForTesting; import 'package:path/path.dart' as path; import 'package:path_provider_linux/path_provider_linux.dart'; import 'package:shared_preferences_platform_interface/shared_preferences_platform_interface.dart'; @@ -74,7 +74,7 @@ class SharedPreferencesLinux extends SharedPreferencesStorePlatform { try { final File? localDataFile = await _getLocalDataFile(); if (localDataFile == null) { - print('Unable to determine where to write preferences.'); + debugPrint('Unable to determine where to write preferences.'); return false; } if (!localDataFile.existsSync()) { @@ -83,7 +83,7 @@ class SharedPreferencesLinux extends SharedPreferencesStorePlatform { final String stringMap = json.encode(preferences); localDataFile.writeAsStringSync(stringMap); } catch (e) { - print('Error saving preferences to disk: $e'); + debugPrint('Error saving preferences to disk: $e'); return false; } return true; diff --git a/packages/shared_preferences/shared_preferences_linux/pubspec.yaml b/packages/shared_preferences/shared_preferences_linux/pubspec.yaml index 88889dcde5fd..cd2ca8007e3c 100644 --- a/packages/shared_preferences/shared_preferences_linux/pubspec.yaml +++ b/packages/shared_preferences/shared_preferences_linux/pubspec.yaml @@ -2,7 +2,7 @@ name: shared_preferences_linux description: Linux implementation of the shared_preferences plugin repository: https://github.com/flutter/plugins/tree/main/packages/shared_preferences/shared_preferences_linux issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22 -version: 2.1.1 +version: 2.1.2 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/shared_preferences/shared_preferences_web/test/tests_exist_elsewhere_test.dart b/packages/shared_preferences/shared_preferences_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/shared_preferences/shared_preferences_web/test/tests_exist_elsewhere_test.dart +++ b/packages/shared_preferences/shared_preferences_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/shared_preferences/shared_preferences_windows/CHANGELOG.md b/packages/shared_preferences/shared_preferences_windows/CHANGELOG.md index 935a5ee54c2b..c486a4ce8f9b 100644 --- a/packages/shared_preferences/shared_preferences_windows/CHANGELOG.md +++ b/packages/shared_preferences/shared_preferences_windows/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 2.1.2 +* Updates code for stricter lint checks. * Updates code for `no_leading_underscores_for_local_identifiers` lint. * Updates minimum Flutter version to 2.10. diff --git a/packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart b/packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart index a60d2ed09926..5cdb30c04e04 100644 --- a/packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart +++ b/packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart @@ -7,7 +7,7 @@ import 'dart:convert' show json; import 'package:file/file.dart'; import 'package:file/local.dart'; -import 'package:flutter/foundation.dart' show visibleForTesting; +import 'package:flutter/foundation.dart' show debugPrint, visibleForTesting; import 'package:path/path.dart' as path; import 'package:path_provider_windows/path_provider_windows.dart'; import 'package:shared_preferences_platform_interface/shared_preferences_platform_interface.dart'; @@ -80,7 +80,7 @@ class SharedPreferencesWindows extends SharedPreferencesStorePlatform { try { final File? localDataFile = await _getLocalDataFile(); if (localDataFile == null) { - print('Unable to determine where to write preferences.'); + debugPrint('Unable to determine where to write preferences.'); return false; } if (!localDataFile.existsSync()) { @@ -89,7 +89,7 @@ class SharedPreferencesWindows extends SharedPreferencesStorePlatform { final String stringMap = json.encode(preferences); localDataFile.writeAsStringSync(stringMap); } catch (e) { - print('Error saving preferences to disk: $e'); + debugPrint('Error saving preferences to disk: $e'); return false; } return true; diff --git a/packages/shared_preferences/shared_preferences_windows/pubspec.yaml b/packages/shared_preferences/shared_preferences_windows/pubspec.yaml index 032e0fb213df..7f97759e6364 100644 --- a/packages/shared_preferences/shared_preferences_windows/pubspec.yaml +++ b/packages/shared_preferences/shared_preferences_windows/pubspec.yaml @@ -2,7 +2,7 @@ name: shared_preferences_windows description: Windows implementation of shared_preferences repository: https://github.com/flutter/plugins/tree/main/packages/shared_preferences/shared_preferences_windows issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22 -version: 2.1.1 +version: 2.1.2 environment: sdk: '>=2.12.0 <3.0.0' diff --git a/packages/url_launcher/url_launcher/example/lib/main.dart b/packages/url_launcher/url_launcher/example/lib/main.dart index a538940f1a68..a870e18a53de 100644 --- a/packages/url_launcher/url_launcher/example/lib/main.dart +++ b/packages/url_launcher/url_launcher/example/lib/main.dart @@ -196,7 +196,6 @@ class _MyHomePageState extends State { onPressed: () => setState(() { _launched = _launchInWebViewOrVC(toLaunch); Timer(const Duration(seconds: 5), () { - print('Closing WebView after 5 seconds...'); closeInAppWebView(); }); }), diff --git a/packages/url_launcher/url_launcher_android/example/lib/main.dart b/packages/url_launcher/url_launcher_android/example/lib/main.dart index 672ae4a27665..68cf334d6656 100644 --- a/packages/url_launcher/url_launcher_android/example/lib/main.dart +++ b/packages/url_launcher/url_launcher_android/example/lib/main.dart @@ -202,7 +202,6 @@ class _MyHomePageState extends State { onPressed: () => setState(() { _launched = _launchInWebView(toLaunch); Timer(const Duration(seconds: 5), () { - print('Closing WebView after 5 seconds...'); launcher.closeWebView(); }); }), diff --git a/packages/url_launcher/url_launcher_ios/example/lib/main.dart b/packages/url_launcher/url_launcher_ios/example/lib/main.dart index 7aa3a4b74e83..6e8ce7431a66 100644 --- a/packages/url_launcher/url_launcher_ios/example/lib/main.dart +++ b/packages/url_launcher/url_launcher_ios/example/lib/main.dart @@ -226,7 +226,6 @@ class _MyHomePageState extends State { onPressed: () => setState(() { _launched = _launchInWebViewOrVC(toLaunch); Timer(const Duration(seconds: 5), () { - print('Closing WebView after 5 seconds...'); UrlLauncherPlatform.instance.closeWebView(); }); }), diff --git a/packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart b/packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart index 14471123ba7d..5f4239ab0ba9 100644 --- a/packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart +++ b/packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart @@ -25,7 +25,7 @@ void main() { uri: uri, target: LinkTarget.blank, builder: (BuildContext context, FollowLink? followLink) { - return Container(width: 100, height: 100); + return const SizedBox(width: 100, height: 100); }, )), )); @@ -43,7 +43,7 @@ void main() { uri: uri2, target: LinkTarget.self, builder: (BuildContext context, FollowLink? followLink) { - return Container(width: 100, height: 100); + return const SizedBox(width: 100, height: 100); }, )), )); @@ -60,7 +60,7 @@ void main() { uri: uri3, target: LinkTarget.self, builder: (BuildContext context, FollowLink? followLink) { - return Container(width: 100, height: 100); + return const SizedBox(width: 100, height: 100); }, )), )); @@ -113,7 +113,7 @@ void main() { uri: null, target: LinkTarget.defaultTarget, builder: (BuildContext context, FollowLink? followLink) { - return Container(width: 100, height: 100); + return const SizedBox(width: 100, height: 100); }, )), )); diff --git a/packages/url_launcher/url_launcher_web/test/tests_exist_elsewhere_test.dart b/packages/url_launcher/url_launcher_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/url_launcher/url_launcher_web/test/tests_exist_elsewhere_test.dart +++ b/packages/url_launcher/url_launcher_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/video_player/video_player_web/test/tests_exist_elsewhere_test.dart b/packages/video_player/video_player_web/test/tests_exist_elsewhere_test.dart index 442c50144727..cc32e6c72f1e 100644 --- a/packages/video_player/video_player_web/test/tests_exist_elsewhere_test.dart +++ b/packages/video_player/video_player_web/test/tests_exist_elsewhere_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_print + import 'package:flutter_test/flutter_test.dart'; void main() { diff --git a/packages/webview_flutter/webview_flutter/example/lib/main.dart b/packages/webview_flutter/webview_flutter/example/lib/main.dart index 79197b02315c..0e712901fe3e 100644 --- a/packages/webview_flutter/webview_flutter/example/lib/main.dart +++ b/packages/webview_flutter/webview_flutter/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert'; diff --git a/packages/webview_flutter/webview_flutter_android/example/lib/main.dart b/packages/webview_flutter/webview_flutter_android/example/lib/main.dart index 4492e6e6e26f..bd958ed8998f 100644 --- a/packages/webview_flutter/webview_flutter_android/example/lib/main.dart +++ b/packages/webview_flutter/webview_flutter_android/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert'; diff --git a/packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart b/packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart index 56745314d92b..b7d98f28684a 100644 --- a/packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart +++ b/packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart @@ -319,10 +319,8 @@ class _PlatformCallbacksHandler implements WebViewPlatformCallbacksHandler { required bool isForMainFrame, }) async { if (url.startsWith('https://www.youtube.com/')) { - print('blocking navigation to $url'); return false; } - print('allowing navigation to $url'); return true; } diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/lib/main.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/lib/main.dart index 3f61ebfdd6f8..c1a456e1169a 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/lib/main.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/lib/main.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_print import 'dart:async'; import 'dart:convert'; diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/lib/web_view.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/lib/web_view.dart index c44c4e743669..11edefb5a34c 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/lib/web_view.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/lib/web_view.dart @@ -639,10 +639,8 @@ class _PlatformCallbacksHandler implements WebViewPlatformCallbacksHandler { required bool isForMainFrame, }) async { if (url.startsWith('https://www.youtube.com/')) { - print('blocking navigation to $url'); return false; } - print('allowing navigation to $url'); return true; } diff --git a/script/tool/analysis_options.yaml b/script/tool/analysis_options.yaml new file mode 100644 index 000000000000..efd40175a208 --- /dev/null +++ b/script/tool/analysis_options.yaml @@ -0,0 +1,5 @@ +include: ../../analysis_options.yaml + +linter: + rules: + avoid_print: false # The tool is a CLI, so printing is normal