From 80e21e090df5d132b1b0a22ea79479734c05e1dc Mon Sep 17 00:00:00 2001 From: Lukas Piliszczuk Date: Wed, 17 Jul 2019 20:25:20 -0400 Subject: [PATCH] [firebase_auth] Fix getIdToken refresh param on iOS (#1869) * Fix refresh param on getIdToken iOS. * Update authors. --- AUTHORS | 1 + packages/firebase_auth/CHANGELOG.md | 4 ++++ packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m | 4 +++- packages/firebase_auth/pubspec.yaml | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index 6650f7423cb3..31a8f62280e0 100644 --- a/AUTHORS +++ b/AUTHORS @@ -40,3 +40,4 @@ Jonathan Younger Jose Sanchez Debkanchan Samadder Audrius Karosevicius +Lukasz Piliszczuk \ No newline at end of file diff --git a/packages/firebase_auth/CHANGELOG.md b/packages/firebase_auth/CHANGELOG.md index 8a9adcfb9b3e..1839016e5267 100644 --- a/packages/firebase_auth/CHANGELOG.md +++ b/packages/firebase_auth/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.11.1+11 + +* On iOS, `getIdToken()` now uses the `refresh` parameter instead of always using `true`. + ## 0.11.1+10 * On Android, `providerData` now includes `UserInfo` for the phone authentication provider. diff --git a/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m b/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m index 90dddc04ef31..bbe6f8c4f283 100644 --- a/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m +++ b/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m @@ -198,8 +198,10 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result [self sendResult:result forObject:nil error:nil]; } } else if ([@"getIdToken" isEqualToString:call.method]) { + NSDictionary *args = call.arguments; + BOOL refresh = [args objectForKey:@"refresh"]; [[self getAuth:call.arguments].currentUser - getIDTokenForcingRefresh:YES + getIDTokenForcingRefresh:refresh completion:^(NSString *_Nullable token, NSError *_Nullable error) { [self sendResult:result forObject:token error:error]; }]; diff --git a/packages/firebase_auth/pubspec.yaml b/packages/firebase_auth/pubspec.yaml index 3b5904d0a0e9..18bca1002fb4 100755 --- a/packages/firebase_auth/pubspec.yaml +++ b/packages/firebase_auth/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS like Google, Facebook and Twitter. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_auth -version: "0.11.1+10" +version: "0.11.1+11" flutter: plugin: