Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_analytics] Fixes errors in firebase_analytics docs #1490

Merged

Conversation

yadaniyil
Copy link
Contributor

Description

Some code examples in firebase_analytics contain errors, e.g. brackets in the wrong place. This PR makes examples launchable.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson collinjackson removed the request for review from kroikie April 14, 2019 16:56
@collinjackson collinjackson merged commit 8cd76d2 into flutter:master Apr 14, 2019
marslord added a commit to marslord/plugins that referenced this pull request Apr 14, 2019
[firebase_analytics] Fixes errors in firebase_analytics docs (flutter#1490)
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…#1490)

Fixes navigation examples in firebase_analytics docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants