Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] onPageStarted, onPageReceiveError callbacks. #1788

Open
wants to merge 9 commits into
base: master
from

Conversation

@just-kip
Copy link

just-kip commented Jul 2, 2019

Description

Add onPageStarted, onPageReceivedError callbacks.
You can catch iOS or Android specific error сodes and http status codes.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.
just-kip added 7 commits Jul 2, 2019
@googlebot googlebot added the cla: yes label Jul 2, 2019
just-kip added 2 commits Jul 2, 2019
@amirh

This comment has been minimized.

Copy link
Contributor

amirh commented Jul 11, 2019

Thanks for the contribution!

I started reviewing this and left a few comments. I'm following the initial PR review policy, this PR isn't trivial to review so I'm labeling it with "backlog" and we will prioritize according to the issue's priority.

Relevant issue: flutter/flutter#25100

@amirh amirh added the backlog label Jul 11, 2019
@@ -25,6 +25,10 @@ abstract class WebViewPlatformCallbacksHandler {

/// Invoked by [WebViewPlatformController] when a page has finished loading.
void onPageFinished(String url);

void onPageReceiveError({String url, int code, String description});

This comment has been minimized.

Copy link
@amirh

amirh Jul 11, 2019

Contributor

Needs Dartdoc

/// Signature for when a [WebView] receive a error.
/// Code may be NSURLErrorDomain code or const from Android WebViewClient or http status code.
/// Description is optional
typedef void PageReceiveErrorCallback(String url, int code, String description);

This comment has been minimized.

Copy link
@amirh

amirh Jul 11, 2019

Contributor

Do we have a guarantee that no WebResourceError code will ever be a valid HTTP response code?

I think we should give developers a single way to detect errors that are the same on all platforms (e.g too many redirects).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.