This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Fix pedantic lints #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daohoangson
added a commit
to daohoangson/plugins
that referenced
this pull request
Dec 7, 2019
…flutter/has_gesture * commit 'be71485431cd5ebaeb7cad4c57ddeb0be910d8b6': (74 commits) [webview_flutter] Add support for onPageStarted event (flutter#2295) adds missing [[ to elif statement in scripts/incremental_build.sh (flutter#2358) [none] Pass --custom-analysis flag through CI (flutter#2356) [video_player] Document public API of video_player_platform_interface. (flutter#2355) [none] Lock pedantic version (flutter#2354) [video_player_platform_interface] Fix some pedantic lints (flutter#2349) Export SignInOption from interface since it is used in the frontend (flutter#2350) Update documentation for connectivity (flutter#2328) [ android_alarm_manager ] Loosen Flutter SDK lower bound, update README (flutter#2338) [e2e_macos] Remove redundant analysis_options.yaml (flutter#2347) Revert "[android_alarm_manager] Update minimum Flutter version to 1.12.0 (flutter#2327)" (flutter#2345) [video_player] Add web implementation using platform interface (flutter#2279) [webview_flutter] Fix pedantic lint errors (flutter#2322) [google_maps_flutter] Add documentation (flutter#2303) [e2e] Fix pedantic lints (flutter#2315) [video_player] Fix pedantic lints (flutter#2321) [share] Fix pedantic lints (flutter#2320) [battery] Fix pedantic linter errors (flutter#2311) [device_info] Fix pedantic errors (flutter#2314) [in_app_purchase] Fix most failing pedantic lints (flutter#2317) ... # Conflicts: # packages/webview_flutter/CHANGELOG.md # packages/webview_flutter/lib/platform_interface.dart # packages/webview_flutter/lib/webview_flutter.dart # packages/webview_flutter/pubspec.yaml
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Fix pedantic lints. This fixes some potential race conditions in cases where futures within some video_player methods weren't being awaited correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
flutter/flutter#45440
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?