Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[e2e] fix flutter driver code snippet in readme and improve formatting of code snippets #2549

Merged
merged 2 commits into from Feb 24, 2020

Conversation

MaikuB
Copy link
Contributor

@MaikuB MaikuB commented Feb 23, 2020

Description

The readme documentation has for the e2e package has a code snippet on how to create a test using Flutter driver. Copying the code snippet there doesn't work as it is incomplete due to missing imports and doesn't declare a variable that is referenced later on.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@MaikuB MaikuB changed the title [e2e] fix flutter driver code snippet in readme and improve formatting [e2e] fix flutter driver code snippet in readme and improve formatting of code snippets Feb 23, 2020
Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaikuB MaikuB requested a review from digiter February 24, 2020 20:00
@MaikuB
Copy link
Contributor Author

MaikuB commented Feb 24, 2020

@digiter Oops sorry misclicked the re-request review button. Noticed build timed out but shouldn't affect this PR as it's an update to a readme file

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@collinjackson collinjackson merged commit 9b96161 into flutter:master Feb 24, 2020
emerssso pushed a commit to emerssso/plugins that referenced this pull request Mar 11, 2020
…g of code snippets (flutter#2549)

* [e2e] fix flutter driver code snippet in readme and improve formatting
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…g of code snippets (flutter#2549)

* [e2e] fix flutter driver code snippet in readme and improve formatting
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…g of code snippets (flutter#2549)

* [e2e] fix flutter driver code snippet in readme and improve formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants