Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[many] Replace deprecated getFlutterEngine calls on Android #2600

Merged
merged 2 commits into from Mar 12, 2020
Merged

[many] Replace deprecated getFlutterEngine calls on Android #2600

merged 2 commits into from Mar 12, 2020

Conversation

creativecreatorormaybenot
Copy link
Contributor

Description

Fixes deprecation of the getFlutterEngine calls on Android by replacing them with getBinaryMessenger.

If you are unsure about this, see the same change for the flutterfire plugins: firebase/flutterfire#2050

Related Issues

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, this is not a breaking change.

@xster
Copy link
Member

xster commented Mar 12, 2020

Related: flutter/flutter#47153

@xster
Copy link
Member

xster commented Mar 12, 2020

LGTM. Thanks

@collinjackson collinjackson merged commit 04a051a into flutter:master Mar 12, 2020
@creativecreatorormaybenot creativecreatorormaybenot deleted the binary-messenger branch March 12, 2020 18:23
@viktor-morin
Copy link

Any ETA on when this will be released?

@xster
Copy link
Member

xster commented Mar 18, 2020

@GaryQian since this PR covers only some aspects of the updates needed at flutter/flutter#47153, let's pub publish them as we go

Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
@creativecreatorormaybenot
[many] Replace deprecated getFlutterEngine calls on Android (flutter#…
ddfed38 
…2600)
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
@creativecreatorormaybenot @EdwinRomelta
[many] Replace deprecated getFlutterEngine calls on Android (flutter#…
badcc7f 
…2600)
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@creativecreatorormaybenot
[many] Replace deprecated getFlutterEngine calls on Android (flutter#…
a7d21e9 
…2600)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@adazh adazh Awaiting requested review from adazh

@amirh amirh Awaiting requested review from amirh

@bkonyi bkonyi Awaiting requested review from bkonyi

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@digiter digiter Awaiting requested review from digiter

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
5 participants
@creativecreatorormaybenot @xster @viktor-morin @collinjackson @googlebot