This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video-player] upgraded video_player_interface to use pigeon #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
gaaclarke
force-pushed
the
video-player-interface-pigeon
branch
from
2233d07
to
0e6a576
Compare
gaaclarke
force-pushed
the
video-player-interface-pigeon
branch
from
0e6a576
to
edd1067
Compare
gaaclarke
force-pushed
the
video-player-interface-pigeon
branch
from
edd1067
to
c6740f8
Compare
|
@cyanglaz Alternatively we could publish this as a whole different package if it makes getting through CI easier. This could be |
|
LGTM |
cyanglaz
approved these changes
May 7, 2020
| int textureId; | ||
| // ignore: unused_element | ||
| Map<dynamic, dynamic> _toMap() { | ||
| final Map<dynamic, dynamic> pigeonMap = <dynamic, dynamic>{}; |
There was a problem hiding this comment.
Not sure if it is possible for pigeon to know the type of the parameters and generate the map with different params.
It's not necessary tho.
There was a problem hiding this comment.
I want to change it to Map<String, dynamic>, i just haven't gotten around to it. I'm kind of stuck with what the standard codec supports.
| 'dev.flutter.pigeon.VideoPlayerApi.initialize', StandardMessageCodec()); | ||
|
|
||
| final Map<dynamic, dynamic> replyMap = await channel.send(null); | ||
| if (replyMap == null) { |
There was a problem hiding this comment.
nits:
can just be
if (xx) {
throw e1;
}
if (yy) {
throw e2;
}
and remove the noop else
| 'dev.flutter.pigeon.VideoPlayerApi.create', StandardMessageCodec()); | ||
|
|
||
| final Map<dynamic, dynamic> replyMap = await channel.send(requestMap); | ||
| if (replyMap == null) { |
There was a problem hiding this comment.
nits:
same here
if
throw
if
throw
return..
|
Landing red as is the protocol that was described to me by @amirh. Look at ecdeb4f to see this passing most CI except the following:
|
stuartmorgan
pushed a commit
to stuartmorgan/plugins
that referenced
this pull request
May 11, 2020
…#2617) * [video-player] upgraded video_player_interface to use pigeon
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…#2617) * [video-player] upgraded video_player_interface to use pigeon
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…#2617) * [video-player] upgraded video_player_interface to use pigeon
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…#2617) * [video-player] upgraded video_player_interface to use pigeon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded to use pigeon, child commit: #2544
Related Issues
Related: flutter/flutter#32930
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?