Add phone auth #606

kroikie · 2018-06-07T23:07:37Z

Update firebase_auth plugin to support phone number authentication.

This PR is a combination of the ideas expressed by @alibitek in PR and @pranjalsatija in PR

pranjalsatija · 2018-06-08T02:32:07Z

@kroikie looks good. Sorry about the formatting issue. I'm having some serious compatibility issues with my computer after upgrading to Mojave.

pranjalsatija · 2018-06-09T23:52:14Z

@kroikie Should we also add a corresponding phoneNumber field to FirebaseUser?

kroikie · 2018-06-11T23:00:58Z

@pranjalsatija good call, added.

mmcc007 · 2018-06-15T02:10:03Z

I tested it on an armv7 (32-bit) iPhone and an android simulator and the example provided worked fine. Nice work.

checked out the PR using

git fetch origin pull/606/head:mybranch
git checkout mybranch

Note have to add phone number +1 408-555-6969 and verifier 888888 to whitelist in Google Console if testing provided example on your own Google project (in addition to the usual handling of google-services.json and GoogleService-Info.plist).

To add it to your own flutter project and see how far you can get, add the following to your pubspec.yaml:

  firebase_auth:
    git:
      url: git@github.com:flutter/plugins.git
      path: packages/firebase_auth
      ref: 075897e

Happy Coding!!

hemesh2394 · 2018-06-15T05:16:46Z

Is firebase auth v 0.5.12 is released?
how i can implement to my project?

mmcc007 · 2018-06-15T06:31:01Z

@hemesh2394 As of this posting, firebase auth v 0.5.12 has not yet been released. This Pull Request tracks the process to release. firebase auth v 0.5.12 is currently considered implemented and must go thru a review process before being released (additional development and review may occur before being released). In the meantime, if you wish to experiment with the new phone feature prior to release, you can use the current (unreleased as of this posting) version by following my suggestion in prior post.

saivamsid · 2018-06-16T15:29:05Z

@mmcc007 how much time will it take for the release of firebase auth v 0.5.12. Thanks

mmcc007 · 2018-06-16T16:24:58Z

@saivamsid I'm not a contributor to this new feature. Just looking at using the new phone auth feature in a flutter app. So I have no input on when it will be released.

gildaswise · 2018-06-26T15:24:26Z

@mmcc007 How did you manage to get the iOS working? Here it just stopped sending the phone verification today on a real device while the simulator still works.

Hixie · 2018-06-26T23:54:17Z

cc @bparrishMines for review

mmcc007 · 2018-06-27T16:47:05Z

@gildaswise I tested it again on an armv7 (32-bit) iPhone and it still works (deleted the user in Google Console -> Authentication). It looks like it will not work without using a normalized phone number (probably conforming to format described in libphonenumber). For example, in my case (in USA) it did not send a verification code if I used the format 14085556969 but did when I used the format +14085556969.

BTW: would be nice if there was a dart implementation of libphonenumber to catch badly formed phone numbers on input (hint... hint... ;) )

gildaswise · 2018-06-27T17:24:07Z

@mmcc007 I don't know what's happening here. I'm using the same number on both simulator and real device (an iPhone 7+) and it is only working on the simulator. This is the only thing missing for a release here. The only difference is that I'm brazilian, so the country code is +55.

mmcc007 · 2018-06-27T17:49:36Z

@gildaswise I assume you are using your real iPhone 7+'s phone number on your real iPhone 7+. Try texting (or have someone from another country text) your real iPhone 7+ using an inbound international format to confirm you are using the correct format for your real iPhone 7+

Per Telephone_numbers_in_Brazil I'm guessing the format should look something like 011 55 aa nnnn nnnn. My guess is to try it without the spaces, so for example for Rio de Janeiro (area code 21) it would be 011552155555555. Worth a try.

gildaswise · 2018-06-27T17:57:01Z

@mmcc007 That didn't work, sadly. As I said, it's only failing on the iPhone 7+ while it works normally with this format: +55 (21) 95555-5555 parsed like this: +5521955555555 on the Android side or the iOS simulator (SE or 8+)

mmcc007 · 2018-06-27T18:10:05Z

@gildaswise Working on a simulator confirms that the code is most likely completely correct.

If you cannot receive a text on your real device from whichever data center Google is texting your confirmation code (datacenter could be in Brazil, or some other country), then, I'm guessing, either you cannot receive international texts on your real device, or the format of the number is incorrect, or possibly something else.

Confirm u can receive international texts on your real device and try different phone number formats, I'm guessing it should eventually work.

gildaswise · 2018-06-27T18:13:01Z

@mmcc007 I tried sending the code to the iPhone 7+'s number from my Google Pixel and it worked. I really don't know what is the problem as all printed logs from inputted numbers are matching.

mmcc007 · 2018-06-27T18:15:34Z

My guess is that your real device has to have a plan from your telephone company that supports international texting.

gildaswise · 2018-06-27T18:16:49Z

I said that it's receiving the code if I do the process from my Android device or the simultator, but it isn't "sending from itself".

mmcc007 · 2018-06-27T18:36:32Z

@gildaswise I assume from your posts that the phone auth of your flutter app works on your real Android device but not on your real iPhone device (in addition to your iPhone simulator). I can confirm I made no special changes for my real iPhone device. It worked first time after it worked on my android simulator.

If both your real iPhone and Android devices have a plan that supports international texting, then I don't know off the top of my head, why you can receive confirmation codes on your real Android device but not on your real iPhone device.

My guess is you're pretty close to solving the problem. I don't know if there is much further I can add.

bparrishMines · 2018-06-28T21:15:42Z

.../firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java

      default:
        result.notImplemented();
        break;
    }
  }

+  private void handleSignInWithPhoneNumber(MethodCall call, Result result) {
+    Map<String, String> arguments = (Map<String, String>) call.arguments;
+    String verificationId = arguments.get("verificationId");


I believe you can just use call.argument("verificationId")

The cast to Map<String, String> would still be necessary so I'll leave it as is.

bparrishMines · 2018-06-28T21:50:42Z

packages/firebase_auth/example/lib/main.dart

@@ -37,6 +37,10 @@ class MyHomePage extends StatefulWidget {

 class _MyHomePageState extends State<MyHomePage> {
  Future<String> _message = new Future<String>.value('');
+  TextEditingController smsCodeController = new TextEditingController();


nit: add underscore to variables like _message

kueckermann · 2018-07-16T10:12:51Z

@AlexandreRoba Have you tried using https instead of ssh? It fixed some fetch issues for me.

firebase_auth:
    git:
      url: https://github.com/flutter/plugins.git
      path: packages/firebase_auth
      ref: 000cd4c7f8b9eba0feef714a08ff8a13f0f81990

AlexandreRoba · 2018-07-16T12:38:30Z

Hello @kueckermann thanks for the tip. It solved the issue. Now why it works on my mac and not in a docker container is mistery :). Cheers, Alex.

xzminx · 2018-07-17T22:53:55Z

I tried out the PR, and it worked fine at first - I got the SMS, entered code and logged in.
Next time I tried to login, it would be an instant login. Worked fine, FirebaseUser gets returned.

Then i tried deleting the FirebaseUser from the console for my phone number.
Next time I try to login in the app (android), I call verifyPhoneNumber() and the verificationCompleted callback is triggered, but the FirebaseUser that is passed is null. I cannot get it to work. I tried signing out but it had no effect.

Any comments on this?

kroikie · 2018-07-18T14:43:00Z

@xzminx Thanks for reporting this, I was able to reproduce and I will submit a fix in another PR.

kroikie · 2018-07-18T17:05:08Z

@xzminx fix for this issue is available in PR

* Add phone auth

probuse · 2018-07-28T15:39:04Z

@kueckermann I am getting
fatal: bad object 000cd4c7f8b9eba0feef714a08ff8a13f0f81990
What should i use for the ref part?
When i use ssh i get:

Permission denied (publickey).
fatal: Could not read from remote repository.

How can i add the dependency for the PR in my flutter project,
Thank you

kroikie · 2018-07-30T15:34:17Z

@probuse Phone Auth has been published in the firebase_auth plugin.

saltpetre · 2018-07-30T16:58:17Z

@gildaswise If you have a chance can you please update your medium article with 0.5.15. Thanks

gildaswise · 2018-07-30T18:23:06Z

@saltpetreca Just updated it! Also, changed a few things related to error handling.

saltpetre · 2018-07-30T18:33:17Z

@gildaswise Thanks Appreciate

padmanabanSampath · 2018-08-18T02:27:52Z

@gildaswise & @kroikie
How to persist the user data for certain period in phone auth, even if the user closes the app?

CasperPas · 2018-08-18T05:05:36Z

@padmanabanSampath you can use shared_preferences plugin

padmanabanSampath · 2018-08-19T03:46:07Z

@CasperPas thanks for your recommendation, any example code snippet will be useful, regarding phone auth token or uid persistence and checking whether the user has signed in before or not, and adding expiry to the shared preference firebase user storage

shriharip · 2018-10-10T11:37:47Z

I am sorry if this is not the right place to raise this issue again. Just opened the issue on flutter (flutter/flutter#22903 ) but was looking for any help!?.

Is a google or any other auth necessary for phone auth or can it be done stand alone. If it can be done stand alone what is the above error message.

˜Thanks

* Add phone auth

kroikie assigned collinjackson Jun 7, 2018

googlebot added the cla: yes label Jun 7, 2018

This was referenced Jun 7, 2018

Add iOS Phone Number Auth #484

Closed

Add Android Firebase phone number authentication #329

Closed

kroikie requested a review from collinjackson June 7, 2018 23:10

kroikie changed the title ~~[WIP] Add phone auth~~ Add phone auth Jun 11, 2018

kroikie added the flutterfire label Jun 13, 2018

zoechi mentioned this pull request Jun 13, 2018

Firebase Phone Number Authentication flutter/flutter#10404

Closed

bparrishMines self-requested a review June 27, 2018 16:52

bparrishMines reviewed Jun 28, 2018

View reviewed changes

kroikie force-pushed the add-phone-auth branch 2 times, most recently from 471373c to 5e5e346 Compare July 17, 2018 00:08

kroikie added 9 commits July 16, 2018 17:14

Add phone auth

02e13c9

bump version number and fix formatting

c0f57b2

Update change log

d7273dd

Fix analyze errors

89f0717

Fix formatting

115fcdf

Add phoneNumber field to UserInfo

da2ff5c

Fix formatting

669ee57

Update READMEs with phone auth details

1f7bb18

fix formatting

4e1a985

kroikie force-pushed the add-phone-auth branch from 5e5e346 to 4e1a985 Compare July 17, 2018 00:15

kroikie merged commit 6f6d15c into flutter:master Jul 17, 2018

kmorkos pushed a commit to kmorkos/plugins that referenced this pull request Jul 19, 2018

Add phone auth (flutter#606)

407ae50

* Add phone auth

mmcc007 mentioned this pull request Nov 1, 2018

All code for examples should be in example dirs brianegan/flutter_architecture_samples#79

Closed

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

Add phone auth (flutter#606)

ff6238d

* Add phone auth

Add phone auth #606

Add phone auth #606

Conversation

kroikie commented Jun 7, 2018

pranjalsatija commented Jun 8, 2018

pranjalsatija commented Jun 9, 2018

kroikie commented Jun 11, 2018

mmcc007 commented Jun 15, 2018

hemesh2394 commented Jun 15, 2018

mmcc007 commented Jun 15, 2018

saivamsid commented Jun 16, 2018

mmcc007 commented Jun 16, 2018

gildaswise commented Jun 26, 2018

Hixie commented Jun 26, 2018

mmcc007 commented Jun 27, 2018

gildaswise commented Jun 27, 2018 • edited Loading

mmcc007 commented Jun 27, 2018

gildaswise commented Jun 27, 2018

mmcc007 commented Jun 27, 2018

gildaswise commented Jun 27, 2018

mmcc007 commented Jun 27, 2018

gildaswise commented Jun 27, 2018

mmcc007 commented Jun 27, 2018

bparrishMines Jun 28, 2018 • edited Loading

Choose a reason for hiding this comment

kroikie Jul 16, 2018

Choose a reason for hiding this comment

bparrishMines Jun 28, 2018

Choose a reason for hiding this comment

kroikie Jul 16, 2018

Choose a reason for hiding this comment

kueckermann commented Jul 16, 2018 • edited Loading

AlexandreRoba commented Jul 16, 2018

xzminx commented Jul 17, 2018

kroikie commented Jul 18, 2018

kroikie commented Jul 18, 2018

probuse commented Jul 28, 2018

kroikie commented Jul 30, 2018

saltpetre commented Jul 30, 2018 • edited Loading

gildaswise commented Jul 30, 2018

saltpetre commented Jul 30, 2018

padmanabanSampath commented Aug 18, 2018

CasperPas commented Aug 18, 2018

padmanabanSampath commented Aug 19, 2018

shriharip commented Oct 10, 2018

gildaswise commented Jun 27, 2018 •

edited

Loading

bparrishMines Jun 28, 2018 •

edited

Loading

kueckermann commented Jul 16, 2018 •

edited

Loading

saltpetre commented Jul 30, 2018 •

edited

Loading