Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Make sensors package Dart 2 compliant. #621

Merged
merged 3 commits into from
Jun 16, 2018
Merged

Make sensors package Dart 2 compliant. #621

merged 3 commits into from
Jun 16, 2018

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Jun 16, 2018

Also add a test.

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Please bump version and add a change log entry. I'm investigating the analyzer error seen on CI.

@mravn-google
Copy link
Contributor

mravn-google commented Jun 16, 2018

flutter analyze seems to go into an infinite loop or something on the sensors package. Investigating.

flutter/flutter#18528

@mehmetf mehmetf merged commit 80fb0c1 into flutter:master Jun 16, 2018
@mehmetf mehmetf deleted the sensor_fix branch June 16, 2018 14:23
@mehmetf
Copy link
Contributor Author

mehmetf commented Jun 16, 2018

Also worth noting that all locally run analyze commands pass but for some reason they fail on cirrus.

@mravn-google
Copy link
Contributor

mravn-google commented Jun 16, 2018

Please don't land on failing CI. It was failing consistently on Travis, cirrus, and locally (using flutter_plugin_tools rather than Flutter CLI directly). I just could not reproduce immediately because of #18528.

Resolved now. Bug introduced by me in flutter_plugin_tools last night.

@mravn-google
Copy link
Contributor

New version published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants