-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Hi @kdy1 Thanks for the PR could you please fix the formatting? I'll be happy to merge then. |
I fixed it. |
Most of them are timeout, but I couldn't find a retry button. |
@kdy1 would you mind rebasing on master and trying again. Some formatting that is failing in your PR should be fixed and we should get a successful build. |
Done, but now I got some more formatting issues.. |
I guess the failure is related to flutter version. Output of
|
@kdy1 Sorry for those errors, those formatting issues have been resolved. Please rebase again and I will merge. |
It failed. I guess I should revert 'format with flutter .`? Is this right? |
Google play games service does not give us displayName. Closes flutter/flutter#19442
* Remove a wrong assertion. Google play games service does not give us displayName. Closes flutter/flutter#19442
* Remove a wrong assertion. Google play games service does not give us displayName. Closes flutter/flutter#19442
This reverts commit d111fd3.
Google play games service does not give us displayName.
Closes flutter/flutter#19442