This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Adding support to setLanguageCode to FirebaseAuth #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroikie
suggested changes
Jul 23, 2018
| @@ -411,6 +411,15 @@ class FirebaseAuth { | |||
| return currentUser; | |||
| } | |||
|
|
|||
| /// Sets the user-facing language code for auth operations that can be | |||
| /// internationalized, such as [sendEmailVerification]. | |||
There was a problem hiding this comment.
Please include the formatting requirements (IETF in BCP47) in this comment.
Eg: as in Android reference docs
|
@ffeu Thanks for the PR, this looks good. Could you please:
|
|
LGTM |
kroikie
approved these changes
Jul 24, 2018
|
Hello, the email await FirebaseAuth.instance.setLanguageCode('es');
final user = await FirebaseAuth.instance.currentUser();
await user.updateEmail('example@gmail.com');I am doing correct? |
|
@basketball-ico PS: the best place for questions like this is stackoverflow. |
|
@ffeu Hi thanks I try this, but the |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Adding support to setLanguageCode to FirebaseAuth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue:
flutter/flutter#19525