From 4a677e5c8e616d2b330c1463430d3fb691c60fcd Mon Sep 17 00:00:00 2001 From: Justin McCandless Date: Mon, 23 Jan 2023 15:21:35 -0800 Subject: [PATCH] Use pumpAndSettle after dragUntilVisible to avoid flakes where the test ListItem cant be found --- experimental/context_menus/test/anywhere_page_test.dart | 1 + experimental/context_menus/test/cascading_menu_page_test.dart | 1 + experimental/context_menus/test/custom_buttons_page_test.dart | 1 + experimental/context_menus/test/custom_menu_page_test.dart | 1 + 4 files changed, 4 insertions(+) diff --git a/experimental/context_menus/test/anywhere_page_test.dart b/experimental/context_menus/test/anywhere_page_test.dart index d8ab8962cdf..8d0bd4f0052 100644 --- a/experimental/context_menus/test/anywhere_page_test.dart +++ b/experimental/context_menus/test/anywhere_page_test.dart @@ -14,6 +14,7 @@ void main() { find.byType(ListView), const Offset(0.0, -100.0), ); + await tester.pumpAndSettle(); await tester.tap(find.text(AnywherePage.title)); await tester.pumpAndSettle(); diff --git a/experimental/context_menus/test/cascading_menu_page_test.dart b/experimental/context_menus/test/cascading_menu_page_test.dart index 13efe287a1e..b8469d17c5b 100644 --- a/experimental/context_menus/test/cascading_menu_page_test.dart +++ b/experimental/context_menus/test/cascading_menu_page_test.dart @@ -15,6 +15,7 @@ void main() { find.byType(ListView), const Offset(0.0, -250.0), ); + await tester.pumpAndSettle(); await tester.tap(find.text(CascadingMenuPage.title)); await tester.pumpAndSettle(); diff --git a/experimental/context_menus/test/custom_buttons_page_test.dart b/experimental/context_menus/test/custom_buttons_page_test.dart index 07266b1a6df..599b2fa4ca0 100644 --- a/experimental/context_menus/test/custom_buttons_page_test.dart +++ b/experimental/context_menus/test/custom_buttons_page_test.dart @@ -17,6 +17,7 @@ void main() { find.byType(ListView), const Offset(0.0, -100.0), ); + await tester.pumpAndSettle(); await tester.tap(find.text(CustomButtonsPage.title)); await tester.pumpAndSettle(); diff --git a/experimental/context_menus/test/custom_menu_page_test.dart b/experimental/context_menus/test/custom_menu_page_test.dart index a7f2272b44f..310d2c875fc 100644 --- a/experimental/context_menus/test/custom_menu_page_test.dart +++ b/experimental/context_menus/test/custom_menu_page_test.dart @@ -16,6 +16,7 @@ void main() { find.byType(ListView), const Offset(0.0, -200.0), ); + await tester.pumpAndSettle(); await tester.tap(find.text(CustomMenuPage.title)); await tester.pumpAndSettle();