Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use button array for survey #100

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Use button array for survey #100

merged 1 commit into from
Jul 27, 2023

Conversation

eliasyishak
Copy link
Contributor

The buttons will be now be contained in an array instead of having hard coded accept and reject texts at the top level

Each button will also have the ability to link to a url specified within the object

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The buttons will be now be contained in an array instead of having hard coded `accept` and `reject` texts at the top level

Each button will also have the ability to link to a url specified within the object
@@ -1,21 +1,34 @@
[
{
"uniqueId": "test_channel",
"url": "https://google.qualtrics.com/jfe/form/SV_5gsB2EuG5Et5Yy2",
"uniqueId": "eca0100a-505b-4539-96d0-57235f816cef",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a UUID generator here for the uniqueId instead of the previous test string

@jayoung-lee jayoung-lee merged commit d620e46 into master Jul 27, 2023
3 checks passed
@eliasyishak eliasyishak deleted the eliasyishak-patch-2 branch July 31, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants