GPU thread --> raster thread #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the “transition period” phase of the change proposed in flutter/flutter#29443 (comment).
googlebot
added
the
cla: yes
sfshaza2
approved these changes
Mar 24, 2020
| @@ -35,7 +35,7 @@ This chart is populated with individual frames as they are rendered | |||
| in your application. Each bar in the chart represents a frame. | |||
| The bars are color-coded to highlight the different portions of | |||
| work that occur when rendering a Flutter frame: work from the UI | |||
| thread and work from the GPU thread. | |||
| thread and work from the raster thread (previously known as GPU thread). | |||
There was a problem hiding this comment.
as GPU thread => as the GPU thread
|
(But let's wait for @liyuqian to review.) |
liyuqian
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
LGTM. This also reveals that we need to rename some GPU in the DevTools too. CC @kenzieschmoll (also CC'ed in the planning Google doc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the “transition period” phase of the change proposed in flutter/flutter#29443 (comment).