Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Adding an Apple Watch extension page #7622

merged 2 commits into from Oct 5, 2022


Copy link

@jmagman jmagman commented Oct 5, 2022

Description of what this PR is changing or adding, and why:

"Adding an Apple Watch extension" page only has two instructions--turn on bitcode, and add the extension. I need to delete the "turn on bitcode" step 1 since Apple has deprecated bitcode flutter/flutter#107887. That leaves a very low-quality page. Delete it.

Issues fixed by this PR (if any): Part of flutter/flutter#107887

Presubmit checklist

@jmagman jmagman changed the title Remove Adding an Apple Watch extension page Remove Adding an Apple Watch extension page Oct 5, 2022
Copy link

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was recently looking at this page and I knew that the bitcode info needed to be removed and I was wondering how we'd do that, so I think this IS the best option. Besides, we ultimately need more generalized info on how to deal with embedded functionality.

@sfshaza2 sfshaza2 merged commit dbfc6fd into flutter:main Oct 5, 2022
10 checks passed
leighajarett pushed a commit to vandadnp/flutter-website that referenced this pull request Nov 8, 2022
* Remove Adding an Apple Watch extension page

* Remove image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants