Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in README using BaseOptions #266

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@omuomugin
Copy link
Contributor

commented Apr 21, 2019

Hey, thanks for such a great http client library.
I was so impressed by this work and I'm know fan of this.

As I follow the introduction in README, I found that BaseOptions usage example was not correctly assigning to the right type. (By the way IDE told me this was error)

Therefore I updated the README for the newbies.
If I was misunderstanding something just let me know.

Thanks

@wendux wendux merged commit efb9efe into flutterchina:master Apr 23, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@wendux

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Yes! you're right, thanks for your pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.