Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share_plus): Show NSSharingServicePicker asynchronously on main thread #1223

merged 3 commits into from Oct 12, 2022


Copy link

@Seuleuzeuh Seuleuzeuh commented Oct 12, 2022


In the MacOS implementation of share_plus show the NSSharingServicePicker asynchronously.

For testing purpose i've update the corresponding sample app :
replace filepicker_windows with file_selector, for a working sample in all desktop (MacOS, Windows, Linux).

Related Issues


  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the example code as well

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 12, 2022
Copy link

Just a note, we need clarification if #1177 refers to iOS or macOS (or both)

Copy link
Contributor Author

Just a note, we need clarification if #1177 refers to iOS or macOS (or both)

Only macOS (the change refer to the file SharePlusMacosPlugin.swift.

@miquelbeltran miquelbeltran merged commit e403cfa into fluttercommunity:main Oct 12, 2022
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants