Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(share_plus)!: two-package federated architecture #1238

merged 10 commits into from Oct 14, 2022


Copy link

@nohli nohli commented Oct 13, 2022


Refactor share_plus from the federated architecture to a platform interface and a package with all platform implementations.

Related Issues



  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member Author

nohli commented Oct 13, 2022

@miquelbeltran maybe the same Windows build issue as here

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 14, 2022
Copy link

this windows build seems fixed now as well. I am not happy with the naming (some files have _windows_, some don't) but it works.

Copy link
Member Author

nohli commented Oct 14, 2022

You're a champ 💪🏽

@nohli nohli marked this pull request as ready for review October 14, 2022 14:33
@nohli nohli merged commit 47dd8be into main Oct 14, 2022
19 checks passed
@nohli nohli deleted the unfederate-share-plus branch October 14, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants