Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): Increase min Flutter version to fix dartPluginClass registration #1275

merged 2 commits into from Oct 20, 2022


Copy link

@miquelbeltran miquelbeltran commented Oct 20, 2022


Fixes the issue where the dart_plugin_registrant.dart file is not generated correctly.

Tested this locally with packages referenced by path. When I increased the Flutter SDK version to 2.11 then the issue we saw in #1270 was gone.

Related Issues


  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member Author

Since we are at it, I have also upgraded the platform interfaces (although not required for this fix) and removed some of the SDK requirements from the examples, as they are not required.

Copy link

CodeDoctorDE commented Oct 20, 2022

Why do we need the platform_interface packages if we only need one package for every platform?

Copy link
Member Author

Why do we need the platform_interface packages if we only need one package for every platform?

It has been a long discussion in the maintainers team, and the conclusion is that having a package interface as an external package allows for expandability. I'd personally get rid of it but not everyone agreed.

Copy link

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great that we are pushing things a little bit and getting rid of these really old versions as well as bumping all plugins at once, getting rid of differences in min supported version.

@miquelbeltran miquelbeltran merged commit 1cb640d into main Oct 20, 2022
88 of 91 checks passed
@miquelbeltran miquelbeltran deleted the fix-1270 branch October 20, 2022 07:29
@miquelbeltran miquelbeltran added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
None yet

Successfully merging this pull request may close these issues.

[Bug]: No implementation found for method getAll on channel
3 participants