New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(share_plus): export XFile #1286
fix(share_plus): export XFile #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@miquelbeltran when this will be published? |
We don't have yet a fixed release schedule, but probably during the coming days |
Ok can you give an ETA as it is blocking #1070 since published version is not exporting XFile Should I make a draft PR by depending using path? |
You can do a draft PR sure, but I am not sure why you need this released to implement another change. Development should always reference the local libraries and not the ones on pub.dev if you do a proper development setup using melos. So you don't even need to add the dependency by path because your pubspec lock already references it. |
I have never used melos. Will try to configure it. Thanks |
It is on the Contributors guide, you need it to bootstrap the repo. Please read the contributors guide carefully and follow it. |
Description
SharePlatform
toplatform_interface/share_plus_platform
.cross_file
andshare_plus_platform
inshare_plus_platform_interface.dart
file (inspiration).export ... show ...;
)XFile
inshare_plus
package (inspiration).XFile
fromfile_selector
andimage_picker
inexample/lib/main.dart
so that this export is tested.wild ideas, not to be taken too seriously:
share_plus_platform_interface/lib
be moved tosrc
(same asimage_picker
)?SharePlatform
be renamed toSharePlusPlatform
?Related Issues
Fixes #1271
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).