Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensors_plus] Fix crash issue on closing application #995

Conversation

thachnb85
Copy link
Contributor

Description

  • Providing additional fixes for the crash issue when closing application.

Related Issues

#981

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@thachnb85 thachnb85 changed the title Fix crash issue on closing application [sensors_plus] Fix crash issue on closing application Aug 2, 2022
@thachnb85 thachnb85 marked this pull request as draft August 2, 2022 23:14
@thachnb85 thachnb85 marked this pull request as ready for review August 2, 2022 23:15
@thachnb85
Copy link
Contributor Author

@miquelbeltran Could you review this? Thank you.

@miquelbeltran
Copy link
Member

Thanks @thachnb85 !

@miquelbeltran miquelbeltran merged commit 2030813 into fluttercommunity:main Aug 3, 2022
Chever-John pushed a commit to Chever-John/plus_plugins that referenced this pull request Aug 30, 2022
…ty#995)

* Additonal fixes for crash issue: "Error: Sending a message before the FlutterEngine has been run."

* Update sensors_plus version to 1.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants