[Merged by Bors] - Support ReadCommitted isolation in SPU for Produce requests
#2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
suggested changes
Apr 28, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
The first pass looks good.
Meantime, can you add integration tests similar to fetch tests?
sehz
suggested changes
Apr 29, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Looks very good. Couple of minor comments
| NotLeaderForPartition, | ||
| #[fluvio(tag = 7)] | ||
| #[error("the request timed out.")] | ||
| RequestTimedOut, |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 2, 2022
The produce handler uses the `acks` field from `ProduceRequest` to determine which isolation will be taken. In case of `ReadCommitted` isolation, it waits until the replica's `hw` includes records from the requests before returning the response. Awaiting is limited by the `timeout_ms` field of the request. For now, the timeout is not shared between partitions, it is counted separately for each partition. For `ReadUncommitted` there is no waiting. Related #2302
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ReadCommitted isolation in SPU for Produce requestsReadCommitted isolation in SPU for Produce requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The produce handler uses the
acksfield fromProduceRequestto determine which isolation will be taken.In case of
ReadCommittedisolation, it waits until the replica'shwincludes records from the requests before returning the response. Awaiting is limited by thetimeout_msfield of the request. For now, the timeout is not shared between partitions, it is counted separately for each partition.For
ReadUncommittedthere is no waiting.Related #2302