[Merged by Bors] - Add custom deserializer for connector yaml #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
suggested changes
Jun 20, 2022
Contributor
Author
|
One thing that might be worth adding to this PR would be adding a top level key of |
tjtelan
suggested changes
Jun 20, 2022
Contributor
tjtelan
left a comment
tjtelan
left a comment
There was a problem hiding this comment.
I think this otherwise looks like a good change
Contributor
My only apprehension is that we don't have a simple interface for SmartModules. We currently need to specify the type of module ( My ideal representation of a smart_modules:
- my_filter
- my_map
- my_aggWhere the SmartModule transforms in the order it is specified, and does not require passing extra info such as what type of SmartModule. Considering the current behavior, I would be ok with smart_module:
name: my_filter
type: filter |
Contributor
Author
I think I like this the most for now. |
simlay
force-pushed
the
add-custom-deserializer-for-connector-yaml
branch
from
498c759 to
b513819
Compare
sehz
suggested changes
Jun 22, 2022
tjtelan
approved these changes
Jun 22, 2022
simlay
force-pushed
the
add-custom-deserializer-for-connector-yaml
branch
from
7e808ef to
d3e1b17
Compare
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Closes #2421 * Closes #2410. This enables the connectors yamls to be thusly: ```yaml version: 0.1.0 name: my-test-mqtt type: mqtt topic: my-mqtt create_topic: false direction: source parameters: param_1: "mqtt.hsl.fi" param_2: foo: bar bar: foo param_3: - "baz" secrets: foo: bar producer: linger: 1ms batch_size: 44 compression: gzip consumer: partition: 10 ```
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to infinyon/fluvio-connectors
that referenced
this pull request
Jun 26, 2022
This is the connectors PR to fluvio-community/fluvio#2426. Still need to do version bumps.
bors bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
This is the non breaking changes changes from #2426.
morenol
pushed a commit
to morenol/fluvio
that referenced
this pull request
Jun 30, 2022
Closes fluvio-community#2437 * [x] Increment patch version in [`VERSION`](https://github.com/infinyon/fluvio/blob/master/VERSION) file * [x] Update [`CHANGELOG`](https://github.com/infinyon/fluvio/blob/master/CHANGELOG.md) with replacement of the `UNRELEASED` date for most recent release * [x] Add a new heading in [`CHANGELOG`](https://github.com/infinyon/fluvio/blob/master/CHANGELOG.md) with for the next release (Use heading level 2) Add specific log_dir creation error (fluvio-community#2425) Previous implementation simply prints: 0: Fluvio cluster error 1: Permission denied (os error 13) ...which gives no information regarding which operation caused the error, or even to which path the error relates. This commit adds an interstitial error to the chain, which prints: 1: An error occurred creating the cluster log directory "/usr/local/var/log/fluvio" Re-added producer config to connector yaml (fluvio-community#2444) This is the non breaking changes changes from fluvio-community#2426. Add VecOrString for ManagedConnectorSpec parameters cargo fmt and clippy Verify some portion of backward compatability backward compatible encoding for manage connector parameters fix serialize issue cargo fmt fix tests Updates from comments Updated watch version Updates from comments fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the connectors yamls to be thusly: