[Merged by Bors] - Fix wasi functions binding relying on order#2428
Closed
galibey wants to merge 3 commits intofluvio-community:masterfrom
galibey:bugfix/wasi-binding-depends-on-order
Closed
[Merged by Bors] - Fix wasi functions binding relying on order#2428galibey wants to merge 3 commits intofluvio-community:masterfrom galibey:bugfix/wasi-binding-depends-on-order
wasi functions binding relying on order#2428galibey wants to merge 3 commits intofluvio-community:masterfrom
galibey:bugfix/wasi-binding-depends-on-order
Conversation
morenol
approved these changes
Jun 22, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
The binding of host function `copy_record` for `wasi` expects that the function always goes first in the list of imports. This is not always correct. Instead of lookup by order, we will do a lookup by name. Also, the PR adds integration tests that will check the smart module instantiation works for both `wasm` and `wasi` cases.
|
Build failed: |
|
clippy strikes... |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
The binding of host function `copy_record` for `wasi` expects that the function always goes first in the list of imports. This is not always correct. Instead of lookup by order, we will do a lookup by name. Also, the PR adds integration tests that will check the smart module instantiation works for both `wasm` and `wasi` cases.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
wasi functions binding relying on orderwasi functions binding relying on order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding of host function
copy_recordforwasiexpects that the function always goes first in the list of imports. This is not always correct. Instead of lookup by order, we will do a lookup by name.Also, the PR adds integration tests that will check the smart module instantiation works for both
wasmandwasicases.