[Merged by Bors] - Fix backward compatibility issues for ManagedConnectorSpec parameters#2446

Closed

simlay wants to merge 13 commits into

fluvio-community:masterfrom

simlay:multi-argument-parameter-backward-compatible-support

Contributor

simlay commented Jun 29, 2022 •

edited

Loading

Closes #2433.

simlay marked this pull request as ready for review

June 29, 2022 18:25

simlay commented

View reviewed changes

crates/fluvio-controlplane-metadata/src/connector/spec.rs

simlay changed the title ~~Add VecOrString for ManagedConnectorSpec parameters~~ Fix backward compatibility issues for ManagedConnectorSpec parameters

morenol reviewed

View reviewed changes

crates/fluvio-cli/src/connector/mod.rs Outdated

morenol reviewed

View reviewed changes

crates/fluvio-cli/src/connector/mod.rs Outdated

morenol reviewed

View reviewed changes

crates/fluvio-cli/src/connector/mod.rs Outdated

morenol reviewed

View reviewed changes

crates/fluvio-cli/src/connector/mod.rs Outdated

morenol reviewed

View reviewed changes

crates/fluvio-sc-schema/src/objects/list.rs

morenol reviewed

View reviewed changes

crates/fluvio-sc/src/k8/controllers/managed_connector_deployment.rs Outdated

morenol reviewed

View reviewed changes

crates/fluvio-cli/src/connector/mod.rs Outdated

nacardin reviewed

View reviewed changes

crates/fluvio-controlplane-metadata/src/connector/spec.rs Outdated

simlay commented

View reviewed changes

crates/fluvio-sc-schema/src/objects/watch.rs

simlay requested review from morenol and nacardin

June 30, 2022 00:22

nacardin approved these changes

View reviewed changes

sehz approved these changes

View reviewed changes

sehz left a comment

LGTM

simlay added 12 commits

June 29, 2022 20:52


          Add VecOrString for ManagedConnectorSpec parameters

2400b18


          cargo fmt and clippy

aba3ab2


          Verify some portion of backward compatability

c51188b


          backward compatible encoding for manage connector parameters

fd1ad6f


          fix serialize issue

5b1ee68


          cargo fmt

24621c2


          fix tests

a96c2cc


          Updates from comments

5098fd1


          Updated watch version

fbe4767


          Updates from comments


          fix ci

130e15e


          Updated changelog

26dc9f8

simlay force-pushed the multi-argument-parameter-backward-compatible-support branch from dccf317 to 26dc9f8 Compare

June 30, 2022 00:53

Contributor Author

simlay commented Jun 30, 2022

bors r+

bors Bot commented Jun 30, 2022

Merge conflict.


          Merge branch 'master' into multi-argument-parameter-backward-compatib…

5b80728

…le-support

sehz commented Jun 30, 2022

bors r+

bors Bot pushed a commit that referenced this pull request


          Fix backward compatibility issues for ManagedConnectorSpec parameters (…

140f783

…#2446)

Closes #2433.

Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>

bors Bot commented Jun 30, 2022

Pull request successfully merged into master.

Build succeeded:

Done

bors Bot changed the title ~~Fix backward compatibility issues for ManagedConnectorSpec parameters~~ [Merged by Bors] - Fix backward compatibility issues for ManagedConnectorSpec parameters

bors Bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet