Skip to content

[Merged by Bors] - Fix #2441#2448

Closed
digikata wants to merge 2 commits intofluvio-community:masterfrom
digikata:cli-kip
Closed

[Merged by Bors] - Fix #2441#2448
digikata wants to merge 2 commits intofluvio-community:masterfrom
digikata:cli-kip

Conversation

@digikata
Copy link
Contributor

@digikata digikata commented Jun 29, 2022

prefer externalIP over internalIP when available

Fix #2441

@sehz
Copy link

sehz commented Jul 6, 2022

need to add changelog

@sehz sehz requested a review from tjtelan July 6, 2022 15:58
digikata added 2 commits July 6, 2022 09:26
prefer externalIP over internalIP when available
@digikata digikata marked this pull request as ready for review July 6, 2022 16:57
@sehz
Copy link

sehz commented Jul 6, 2022

can you link to the issue? This is usually inserted by Github by adding "resolving #xxxx" in the comment.

Copy link

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz
Copy link

sehz commented Jul 6, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 6, 2022
prefer externalIP over internalIP when available

Fix #2441
@bors
Copy link

bors bot commented Jul 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Fix #2441 [Merged by Bors] - Fix #2441 Jul 6, 2022
@bors bors bot closed this Jul 6, 2022
@digikata digikata deleted the cli-kip branch December 15, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CLI tries to use the k8s Node's InternalIP instead of the ExternalIP when reaching the public SC endpoint

3 participants