[Merged by Bors] - Keep serving incoming requests even if socket closed to write #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
This change is needed for `at most once` delivery semantic. The client can send a batch and close the socket without waiting for a response. If the server can't write response it should continue to handle incoming requests that are received and waiting to be served. Related #2481 Co-authored-by: Alexander Galibey <48586936+galibey@users.noreply.github.com>
|
Build failed: |
Contributor
Author
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
This change is needed for `at most once` delivery semantic. The client can send a batch and close the socket without waiting for a response. If the server can't write response it should continue to handle incoming requests that are received and waiting to be served. Related #2481 Co-authored-by: Alexander Galibey <48586936+galibey@users.noreply.github.com>
|
Build failed: |
Contributor
Author
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
This change is needed for `at most once` delivery semantic. The client can send a batch and close the socket without waiting for a response. If the server can't write response it should continue to handle incoming requests that are received and waiting to be served. Related #2481 Co-authored-by: Alexander Galibey <48586936+galibey@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for
at most oncedelivery semantic. The client can send a batch and close the socket without waiting for a response. If the server can't write response it should continue to handle incoming requests that are received and waiting to be served.Related #2481