[Merged by Bors] - Support async response in socket #2488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
suggested changes
Jul 15, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Overall looks good. Just few minor nits
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
Added an ability to receive a response asynchronously. We re-use the current functionality of `AsyncResponse` and streaming, just saying that `AsyncResponse` is now also a Future that can resolve to one result instead of a sequence of results for the streaming case. Related #2481
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ability to receive a response asynchronously. We re-use the current functionality of
AsyncResponseand streaming, just saying thatAsyncResponseis now also a Future that can resolve to one result instead of a sequence of results for the streaming case.Related #2481