[Merged by Bors] - Add AtMostOnce and AtLeastOnce delivery semantics#2503
Closed
galibey wants to merge 2 commits intofluvio-community:masterfrom
galibey:feature/2481-add-delivery-semantics-to-producer
Closed
[Merged by Bors] - Add AtMostOnce and AtLeastOnce delivery semantics#2503galibey wants to merge 2 commits intofluvio-community:masterfrom galibey:feature/2481-add-delivery-semantics-to-producer
AtMostOnce and AtLeastOnce delivery semantics#2503galibey wants to merge 2 commits intofluvio-community:masterfrom
galibey:feature/2481-add-delivery-semantics-to-producer
Conversation
morenol
approved these changes
Jul 26, 2022
Collaborator
morenol
left a comment
morenol
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me!
|
Can you link to existing issue? |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
Added two delivery semantics to Producer:
1. `AtMostOnce` - we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record.
2. `AtLeastOnce` - we send records, wait for the response and retry if a network error occurs.
The default retry policy:
retries: 4,
max timeout: 300s
delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
AtMostOnce and AtLeastOnce delivery semanticsAtMostOnce and AtLeastOnce delivery semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two delivery semantics to Producer:
1.
AtMostOnce- we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record.2.
AtLeastOnce- we send records, wait for the response and retry if a network error occurs.The default retry policy:
retries: 4,
max timeout: 300s
delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)
Related #2481