[Merged by Bors] - feat(cli): added proxy support during packages installation#2535
Closed
galibey wants to merge 2 commits intofluvio-community:masterfrom
galibey:bugfix/2517-fix-install-behind-proxy
Closed
[Merged by Bors] - feat(cli): added proxy support during packages installation#2535galibey wants to merge 2 commits intofluvio-community:masterfrom galibey:bugfix/2517-fix-install-behind-proxy
galibey wants to merge 2 commits intofluvio-community:masterfrom
galibey:bugfix/2517-fix-install-behind-proxy
Conversation
sehz
suggested changes
Aug 4, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
LGTM. A minor nit about the crate version.
|
nice use of semantic changelog! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
Migrated to `isahc` crate that uses `libcurl`, which gives us more consistent package installation including support of `http_proxy` and `https_proxy` environment variables. Fixes #2517
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to
isahccrate that useslibcurl, which gives us more consistent package installation including support ofhttp_proxyandhttps_proxyenvironment variables.Fixes #2517