[Merged by Bors] - feat(SmartModule): Support chaining#2618
Closed
sehz wants to merge 10 commits intofluvio-community:masterfrom
Closed
[Merged by Bors] - feat(SmartModule): Support chaining#2618sehz wants to merge 10 commits intofluvio-community:masterfrom
sehz wants to merge 10 commits intofluvio-community:masterfrom
Conversation
sehz
force-pushed
the
smartmodule_chaining
branch
from
a935452 to
00ab411
Compare
added 2 commits
September 25, 2022 18:32
sehz
changed the title
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
This PR enables SmartModule chaining processing end to end. No optimization is enabled. It just re-uses the existing mechanism to pass records from the output from one SmartModule to another SmartModule by Engine. Hence it is not efficient. Once we implement WASM Component Model, we can pass output from a SmartModule to another SmartModule. With chaining, SmartModules can be chaining like: `filter -> map -> aggregate`, or `map -> filter -> aggregate`, or `filter -> map -> map -> ` SmartModules can be in any order. With this implementation, there is no validation of the records type. If `filter` and `map` are different data types, it will return an error. For example, you can't mix JSON map and string filter.
|
Build failed: |
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
This PR enables SmartModule chaining processing end to end. No optimization is enabled. It just re-uses the existing mechanism to pass records from the output from one SmartModule to another SmartModule by Engine. Hence it is not efficient. Once we implement WASM Component Model, we can pass output from a SmartModule to another SmartModule. With chaining, SmartModules can be chaining like: `filter -> map -> aggregate`, or `map -> filter -> aggregate`, or `filter -> map -> map -> ` SmartModules can be in any order. With this implementation, there is no validation of the records type. If `filter` and `map` are different data types, it will return an error. For example, you can't mix JSON map and string filter.
|
Build failed: |
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
This PR enables SmartModule chaining processing end to end. No optimization is enabled. It just re-uses the existing mechanism to pass records from the output from one SmartModule to another SmartModule by Engine. Hence it is not efficient. Once we implement WASM Component Model, we can pass output from a SmartModule to another SmartModule. With chaining, SmartModules can be chaining like: `filter -> map -> aggregate`, or `map -> filter -> aggregate`, or `filter -> map -> map -> ` SmartModules can be in any order. With this implementation, there is no validation of the records type. If `filter` and `map` are different data types, it will return an error. For example, you can't mix JSON map and string filter.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables SmartModule chaining processing end to end.
No optimization is enabled. It just re-uses the existing mechanism to pass records from the output from one SmartModule to another SmartModule by Engine. Hence it is not efficient. Once we implement WASM Component Model, we can pass output from a SmartModule to another SmartModule.
With chaining, SmartModules can be chaining like:
filter -> map -> aggregate, ormap -> filter -> aggregate, orfilter -> map -> map ->SmartModules can be in any order. With this implementation, there is no validation of the records type. If
filterandmapare different data types, it will return an error. For example, you can't mix JSON map and string filter.