[Merged by Bors] - fix: Standardize reading records from CLI input#2756
Closed
tjtelan wants to merge 9 commits intofluvio-community:masterfrom
tjtelan:smdk-test-file
Closed
[Merged by Bors] - fix: Standardize reading records from CLI input#2756tjtelan wants to merge 9 commits intofluvio-community:masterfrom tjtelan:smdk-test-file
tjtelan wants to merge 9 commits intofluvio-community:masterfrom
tjtelan:smdk-test-file
Conversation
sehz
suggested changes
Oct 26, 2022
sehz
suggested changes
Oct 29, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Generally looks good. The only issue is that we should put this into the feature flag
Added support for keys
[skip ci]
[skip ci]
tjtelan
changed the title
sehz
suggested changes
Nov 1, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Much better. The remaining question is whether to add to make producer-file as an optional feature to CLI's ? It just seems to add more complexity.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
Resolves #2755 `smdk test --file <file>` by default will read in file and treat each line as a separate record. If you want to read file as a single record, you need to pass in additional flag `--raw`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2755
smdk test --file <file>by default will read in file and treat each line as a separate record.If you want to read file as a single record, you need to pass in additional flag
--raw