[Merged by Bors] - feat(smartmodule): added smartmodule chain support for consumer#2759
Closed
galibey wants to merge 3 commits intofluvio-community:masterfrom
galibey:feat/support-chaining-for-consumers
Closed
[Merged by Bors] - feat(smartmodule): added smartmodule chain support for consumer#2759galibey wants to merge 3 commits intofluvio-community:masterfrom galibey:feat/support-chaining-for-consumers
galibey wants to merge 3 commits intofluvio-community:masterfrom
galibey:feat/support-chaining-for-consumers
Conversation
sehz
suggested changes
Oct 29, 2022
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Generally looks very good. Can you make sure all released crate version is bump up otherwise will not pass bors.
Also, can you test SmartModule works with stable version?
|
Tested with the stable version of Fluvio. Works fine. |
sehz
approved these changes
Oct 31, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
Added support for multiple smartmodules in `StreamFetchRequest` and removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
davidbeesley
pushed a commit
to davidbeesley/fluvio
that referenced
this pull request
Oct 31, 2022
…io-community#2759) Added support for multiple smartmodules in `StreamFetchRequest` and removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for multiple smartmodules in
StreamFetchRequestand removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.