t2008-althash.t errors

[chu11]

I'm seeing on catalyst and hype2 this sometimes

not ok 5 - Attempt to start instance with invalid hash fails hard

with debug

lt-flux-broker: configuring attributes: Invalid argument
E: (flux-broker) 17-05-16 15:10:03 dangling 'PAIR' socket created at src/zsys.c:379
E: (flux-broker) 17-05-16 15:10:03 dangling 'PAIR' socket created at src/zsys.c:380
E: (flux-broker) 17-05-16 15:10:03 dangling 'REP' socket created at src/zauth.c:77
E: (flux-broker) 17-05-16 15:10:03 dangling 'ROUTER' socket created at overlay.c:479
E: (flux-broker) 17-05-16 15:10:03 dangling sockets: cannot terminate ZMQ safely
lt-flux-broker: src/zsock_option.c:1347: zsock_set_sndtimeo: Assertion `rc == 0 || zmq_errno () == (156384712 + 53)' failed.
./sharness.sh: line 504: 27842 Aborted                 (core dumped) "$@"
test_must_fail: died by signal: flux start -o,-Scontent.hash=wronghash /bin/true
not ok 5 - Attempt to start instance with invalid hash fails hard
#	
#	    test_must_fail flux start -o,-Scontent.hash=wronghash /bin/true
#	

It appears #1036 causes a failure that's "too hard" of a failure

[garlick]

FWIW: Just hit this one in c9.io (Ubuntu 14.04.2 LTS), though in a dozen manual runs I couldn't reproduce it.

[chu11]

For me on catalyst it is occurring quite frequently, perhaps atleast 50% of the time.

[garlick]

Looks like content_cache_register_attrs () could be called much earlier. I wonder if that helps?

diff --git a/src/broker/broker.c b/src/broker/broker.c
index 199f1cd..a33c939 100644
--- a/src/broker/broker.c
+++ b/src/broker/broker.c
@@ -348,6 +348,8 @@ int main (int argc, char *argv[])
         if ((e = argz_create (argv + optind, &ctx.init_shell_cmd, &ctx.init_shell_cmd_len)) != 0)
             log_errn_exit (e, "argz_create");
     }
+    if (content_cache_register_attrs (ctx.cache, ctx.attrs) < 0)
+        log_err_exit ("content cache attributes");
 
     /* Record the instance owner: the effective uid of the broker.
      * Set default rolemask for messages sent with flux_send()
@@ -497,8 +499,7 @@ int main (int argc, char *argv[])
             || attr_add_active_int (ctx.attrs, "tbon.descendants",
                                 &ctx.tbon.descendants,
                                 FLUX_ATTRFLAG_IMMUTABLE) < 0
-            || hello_register_attrs (ctx.hello, ctx.attrs) < 0
-            || content_cache_register_attrs (ctx.cache, ctx.attrs) < 0) {
+            || hello_register_attrs (ctx.hello, ctx.attrs) < 0) {
         log_err_exit ("configuring attributes");
     }

[chu11]

It does seem to help. make -j16 check passed 8/8 times, which was much better success than what I had before.