Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimum hwloc version to 1.11.1 #1478

Merged
merged 2 commits into from Apr 19, 2018

Conversation

garlick
Copy link
Member

@garlick garlick commented Apr 19, 2018

This bumps the minimum hwloc version to 1.11.1 to address an assertion failure, as sleuthed out by @grondo and @dongahn over in flux-framework/flux-sched#316.

Problem: hwloc-1.11.0 asserts when ingesting sierra
hwloc XML.

hwloc-1.11.1 contains a fix for this so bump
the minimum version in configure.ac.

This was discussed in flux-framework/flux-sched#316.
Bump the hwloc version built in travis to match the new
minimum required version.
@grondo
Copy link
Contributor

grondo commented Apr 19, 2018

Thanks for jumping on this!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 79.034% when pulling f66589a on garlick:hwloc_update into 7248668 on flux-framework:master.

@codecov-io
Copy link

Codecov Report

Merging #1478 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   78.76%   78.73%   -0.04%     
==========================================
  Files         164      164              
  Lines       30328    30328              
==========================================
- Hits        23889    23878      -11     
- Misses       6439     6450      +11
Impacted Files Coverage Δ
src/modules/connector-local/local.c 72.95% <0%> (-1.64%) ⬇️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/common/libflux/future.c 88.31% <0%> (-0.47%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/message.c 81.25% <0%> (-0.12%) ⬇️
src/common/libflux/handle.c 84.15% <0%> (+0.49%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
src/broker/modservice.c 81.55% <0%> (+0.97%) ⬆️

@grondo grondo merged commit f8aae6c into flux-framework:master Apr 19, 2018
@grondo grondo mentioned this pull request May 10, 2018
@garlick garlick deleted the hwloc_update branch February 25, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants