allow python under sharness to find modules installed with pip --user #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Python can't find modules installed by pip install --user in the testsuite because sharness reassignes the HOME variable. Deduce the real HOME and assign it to REAL_HOME in sharness.d/01-setup.sh. Use this variable to append the true `site.USER_SITE` path to PYTHONPATH. Fixes flux-framework#1924
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
=========================================
+ Coverage 80.07% 80.1% +0.02%
=========================================
Files 195 195
Lines 35080 35080
=========================================
+ Hits 28092 28100 +8
+ Misses 6988 6980 -8
|
|
Thanks for running this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem described in #1924 by determining the real
HOMEin01-setup.shand appendingsite.USER_SITEfrom python toPYTHONPATHbefore executing tests. This allows python to find user site installed installed modules (e.g. withpip install --user), even though sharness reassigns theHOMEvariable.