broker: fix a problem bootstrapping under openpmix PMI-1 compat library #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: openpmix's libpmi.so PMI_KVS_Get_my_name() fails with PMI_ERR_INVALID_LENGTH if the kvsname buffer size is less than its internal PMIX_MAX_NSLEN (255) value, regardless of the size of the returned string. Work around this by raising the broker's kvsname buffer size from 64 to 1024 bytes. Fixes flux-framework#2746
|
LGTM! Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
+ Coverage 81.46% 81.48% +0.02%
==========================================
Files 248 248
Lines 39025 39025
==========================================
+ Hits 31790 31799 +9
+ Misses 7235 7226 -9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets around an apparent incompatibility with openpmix's PMI compat library by increasing the PMI kvsname buffer size used in the broker.
Edit: dropped flux-pfoxy(1) since @dongahn already submitted it as a separate PR.