New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/flux-kvs: Remove legacy --json options and json output #2807
Conversation
Doh, missed that |
@SteVwonder tested this and found the following works: < flux --parent kvs put -j "tree-perf=${blurb}" || warn "KVS error"
> flux --parent kvs put --raw "tree-perf=-" <<< "${blurb}" || warn "KVS error" |
Hmmm, asan builder hung (which I think happens once in awhile), but had one builder just fail with
Not really sure about what could have caused this. also, found typo in a commit message and I forgot 1 |
Hmmm asan builder got
caused by
Which likely came from
I'm guessing 1.0 seconds timed out ... Added a patch to increase that timeout, re-pushed PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! This looks good to me.
Remove all use of the flux kvs get & put --json option in tests. Adjust tests appropriately. In some cases, tests are removed because they were --json specific. Most adjustments of tests have to do with minor formatting. For example, take the following put & get. flux kvs put --json val="[1,3,5]" flux kvs get --json val This test might have previously checked for the output of "[1, 3, 5]" because internal json libraries would have added spaces when outputting the json array. Without --json, the raw "[1,3,5]" input is preserved.
Remove --json option for get & put. Update manpage appropriately. Fixes flux-framework#2796
By default, the kvs dir command will output any values that are in json format in a special json formatting. Do not do this, just output normally. Adjust tests appropriately.
Increase timeout when looking for lua posix module.
Per #2796, remove legacy
--json
options in flux kvs and remove json output fromflux kvs dir
.The meat of this PR is the changing on the tests, which is in 1 huge commit. Outside of just removing the
--json
calls, there had to be tweaks to the tests and the removal of a few that were--json
specific.