Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 638 - Remove live module #1003

Merged
merged 3 commits into from Mar 14, 2017

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Mar 14, 2017

No description provided.

@chu11 chu11 force-pushed the chu11:issue638 branch from ded8840 to c88d464 Mar 14, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.5%) to 76.983% when pulling c88d464 on chu11:issue638 into 44fdb7a on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #1003 into master will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   76.19%   76.69%   +0.49%     
==========================================
  Files         153      151       -2     
  Lines       26556    25954     -602     
==========================================
- Hits        20235    19906     -329     
+ Misses       6321     6048     -273
Impacted Files Coverage Δ
src/cmd/flux-comms.c 35.29% <ø> (+6.72%)
src/common/libflux/reparent.c 0% <0%> (-42.86%)
src/common/libflux/heartbeat.c 82.6% <0%> (-4.35%)
src/broker/overlay.c 62.26% <0%> (-2.21%)
src/broker/module.c 81.62% <0%> (-1.36%)
src/broker/content-cache.c 71.36% <0%> (-1.33%)
src/broker/broker.c 66.05% <0%> (-0.49%)
src/common/libflux/handle.c 85.52% <0%> (-0.26%)
src/common/libutil/shortjson.h 91.34% <0%> (-0.04%)
src/modules/kvs/kvs.c 81.02% <0%> (+0.12%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fdb7a...c88d464. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.5%) to 76.98% when pulling c88d464 on chu11:issue638 into 44fdb7a on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Mar 14, 2017

Nice, that got our code coverage up to ~77%!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 14, 2017

Yay, I hope these negative lines of code don't go in my PA!

@garlick garlick merged commit 0d6ff9c into flux-framework:master Mar 14, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 44fdb7a...c88d464
Details
codecov/project 76.69% (+0.49%) compared to 44fdb7a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 76.98%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.