Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/proxy: Add event test to increase coverage #1004

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Mar 14, 2017

In particular, cover op_event_subscribe() and op_event_unsubscribe()
in ssh connector.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.05%) to 76.521% when pulling f020b99 on chu11:sshconnectortests into 44fdb7a on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #1004 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   76.69%   76.78%   +0.08%     
==========================================
  Files         151      151              
  Lines       25954    25954              
==========================================
+ Hits        19905    19928      +23     
+ Misses       6049     6026      -23
Impacted Files Coverage Δ
src/common/libflux/rpc.c 90.74% <0%> (-0.75%)
src/common/libflux/handle.c 85.78% <0%> (-0.26%)
src/modules/kvs/kvs.c 81.02% <0%> (+0.24%)
src/common/libflux/message.c 83.64% <0%> (+0.24%)
src/connectors/ssh/ssh.c 85.51% <0%> (+10.28%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6ff9c...aea2934. Read the comment docs.

test/proxy: Add event test to increase coverage
In particular, cover op_event_subscribe() and op_event_unsubscribe()
in ssh connector.

@chu11 chu11 force-pushed the chu11:sshconnectortests branch from f020b99 to aea2934 Mar 14, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.09%) to 77.062% when pulling aea2934 on chu11:sshconnectortests into 0d6ff9c on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Mar 14, 2017

Woo-hoo! 77% crossed

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 14, 2017

Great, thanks!

@garlick garlick merged commit 0071f76 into flux-framework:master Mar 14, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 0d6ff9c...aea2934
Details
codecov/project 76.78% (+0.08%) compared to 0d6ff9c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 77.062%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.