Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue495 - Cleanup #2 #1008

Merged
merged 11 commits into from Mar 17, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Mar 17, 2017

Minor fixes/cleanup found while fixing issue #495. Split off PR before the bigger fix PR. Also includes minor test additions.

chu11 added some commits Feb 28, 2017

cmd/hwloc: Refactor rpc usage
Refactor to use flux_rpc_getf() over flux_rpc_get().  As result, refactor
json_object out of struct hwloc_topo, as it is no longer necessary.
test/kvs: Refactor rpc usage
Refactor to use jansson style rpcs, replace flux_rpc_get() call with
flux_rpc_getf().
broker/exec: Fix errnum success logic error
Fix logic error from commit f0ed4b8

errnum = 0 should be set inside the branch conditional, not outside
of it.
modules/cron: Fix error logic bug
Do not assume that errno always is EPROTO, it could be something else.

@chu11 chu11 force-pushed the chu11:issue495-cleanup2 branch from 130e252 to 5fbb5a5 Mar 17, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 17, 2017

Coverage Status

Coverage increased (+0.008%) to 77.622% when pulling 5fbb5a5 on chu11:issue495-cleanup2 into f81ab5c on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #1008 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   77.29%   77.29%   -0.01%     
==========================================
  Files         151      151              
  Lines       25754    25751       -3     
==========================================
- Hits        19907    19904       -3     
  Misses       5847     5847
Impacted Files Coverage Δ
src/common/libflux/content.c 86.66% <ø> (ø)
src/broker/ping.c 66.03% <ø> (ø)
src/broker/exec.c 86.5% <100%> (+0.06%)
src/modules/cron/cron.c 81.45% <50%> (+0.04%)
src/cmd/builtin/hwloc.c 80.59% <66.66%> (-0.7%)
src/common/libflux/rpc.c 90.74% <0%> (-0.75%)
src/common/libflux/message.c 83.64% <0%> (-0.13%)
src/common/libflux/handle.c 85.78% <0%> (+0.25%)
src/common/libflux/response.c 85% <0%> (+0.83%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81ab5c...5fbb5a5. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 17, 2017

Coverage Status

Coverage decreased (-0.003%) to 77.611% when pulling 5fbb5a5 on chu11:issue495-cleanup2 into f81ab5c on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Mar 17, 2017

code coverage misses appear to be mostly error paths

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 17, 2017

Looks good, thanks!

@garlick garlick merged commit 2d3820a into flux-framework:master Mar 17, 2017

2 of 4 checks passed

codecov/patch 66.66% of diff hit (target 77.29%)
Details
codecov/project 77.29% (-0.01%) compared to f81ab5c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 77.611%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.