Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests to increase code coverage #1011

Merged
merged 4 commits into from Mar 21, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Mar 17, 2017

Added tests for flux_lspeer(), flux_rmmod(), flux_lsmod(), and flux_insmod().

A couple of minor cleanups along the way.

chu11 added some commits Mar 17, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 17, 2017

Coverage Status

Coverage increased (+0.3%) to 77.947% when pulling d7cbad1 on chu11:coverage into 2d3820a on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #1011 into master will increase coverage by 0.33%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   77.29%   77.63%   +0.33%     
==========================================
  Files         151      151              
  Lines       25751    25751              
==========================================
+ Hits        19905    19992      +87     
+ Misses       5846     5759      -87
Impacted Files Coverage Δ
src/cmd/flux-comms.c 43.13% <0%> (+7.84%)
src/modules/kvs/kvs.c 80.59% <0%> (-0.25%)
src/common/libflux/message.c 83.39% <0%> (-0.13%)
src/broker/broker.c 70.63% <0%> (+0.38%)
src/common/libflux/handle.c 86.04% <0%> (+0.51%)
src/broker/overlay.c 71.06% <0%> (+1.88%)
src/common/libflux/module.c 79.26% <0%> (+29.95%)
src/common/libflux/reparent.c 42.85% <0%> (+42.85%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3820a...d7cbad1. Read the comment docs.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Mar 18, 2017

77.947% ... so close :-)

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 21, 2017

Thanks! Merging.

@garlick garlick merged commit e07ed32 into flux-framework:master Mar 21, 2017

3 of 4 checks passed

codecov/patch 0% of diff hit (target 77.29%)
Details
codecov/project 77.63% (+0.33%) compared to 2d3820a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 77.947%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.