Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/security: Fix test corner case #1029

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Apr 5, 2017

Check for EACCES depends on system setup and errno may be something
else such as EROFS or EPERM. Genericize test to simply check for
failure.

test/security: Fix test corner case
Check for EACCES depends on system setup and errno may be something
else such as EROFS or EPERM.  Genericize test to simply check for
failure.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #1029 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   77.91%   77.87%   -0.04%     
==========================================
  Files         150      150              
  Lines       25494    25494              
==========================================
- Hits        19863    19853      -10     
- Misses       5631     5641      +10
Impacted Files Coverage Δ
src/common/libflux/info.c 76.11% <0%> (-2.99%) ⬇️
src/common/libflux/request.c 89.04% <0%> (-1.37%) ⬇️
src/common/libflux/rpc.c 91.17% <0%> (-1.11%) ⬇️
src/broker/module.c 82.15% <0%> (-0.29%) ⬇️
src/common/libflux/dispatch.c 83.15% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 85.52% <0%> (-0.26%) ⬇️
src/common/libflux/message.c 80.77% <0%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac055a9...7d891ae. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2017

Coverage Status

Changes Unknown when pulling 7d891ae on chu11:issue1028 into ** on flux-framework:master**.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 5, 2017

Thanks @chu11, looks good.

@garlick garlick merged commit a9f4cd5 into flux-framework:master Apr 5, 2017

3 of 4 checks passed

codecov/project 77.87% (-0.04%) compared to ac055a9
Details
codecov/patch Coverage not affected when comparing ac055a9...7d891ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.184%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.