Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/connector-local: Fix compiler warning #1031

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Apr 7, 2017

In if statement caller checks return value from function both != 0
and non-NULL. Remove the != 0 check.

modules/connector-local: Fix compiler warning
In if statement caller checks return value from function both != 0
and non-NULL.  Remove the != 0 check.
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 7, 2017

Found this while working on #1030 and trying the clang 3.9 compiler.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 7, 2017

Sheesh! Sorry.

Will merge once travis completes unless you have more to add.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 7, 2017

Nope, this is it.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 7, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.188% when pulling 846d475 on chu11:misccleanup4 into a9f4cd5 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 7, 2017

Codecov Report

Merging #1031 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage    77.9%   77.87%   -0.04%     
==========================================
  Files         150      150              
  Lines       25494    25494              
==========================================
- Hits        19862    19854       -8     
- Misses       5632     5640       +8
Impacted Files Coverage Δ
src/modules/connector-local/local.c 70.14% <ø> (+0.2%) ⬆️
src/cmd/builtin/proxy.c 72.81% <0%> (-1.59%) ⬇️
src/cmd/flux-event.c 65.55% <0%> (-1.12%) ⬇️
src/common/libflux/rpc.c 90.44% <0%> (-0.74%) ⬇️
src/common/libutil/veb.c 98.29% <0%> (-0.57%) ⬇️
src/common/libflux/handle.c 85.52% <0%> (-0.52%) ⬇️
src/bindings/lua/flux-lua.c 81.47% <0%> (-0.1%) ⬇️
src/modules/kvs/kvs.c 80.62% <0%> (+0.12%) ⬆️
src/common/libflux/message.c 80.89% <0%> (+0.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f4cd5...846d475. Read the comment docs.

@garlick garlick merged commit 6fbe380 into flux-framework:master Apr 7, 2017

3 of 4 checks passed

codecov/project 77.87% (-0.04%) compared to a9f4cd5
Details
codecov/patch Coverage not affected when comparing a9f4cd5...846d475
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.188%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.