Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue998: Add missing manpages, minor manpage fixes #1045

Merged
merged 3 commits into from Apr 24, 2017

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Apr 22, 2017

No description provided.

doc/man3: Fix EPROTO error cause
Fixes from Issue 495 / merge a549739
alter the reasons for why some functions return EPROTO.  Adjust
documentation appropriately for those changes.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 22, 2017

Codecov Report

Merging #1045 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   77.92%   77.92%   -0.01%     
==========================================
  Files         150      150              
  Lines       25684    25684              
==========================================
- Hits        20015    20013       -2     
- Misses       5669     5671       +2
Impacted Files Coverage Δ
src/modules/connector-local/local.c 70.49% <0%> (-1.23%) ⬇️
src/cmd/flux-event.c 65.55% <0%> (-1.12%) ⬇️
src/common/libflux/handle.c 85.86% <0%> (-0.26%) ⬇️
src/common/libflux/message.c 81.32% <0%> (+0.24%) ⬆️
src/common/libflux/dispatch.c 83.51% <0%> (+0.27%) ⬆️
src/common/libflux/rpc.c 91.2% <0%> (+0.73%) ⬆️
src/common/libflux/response.c 84.61% <0%> (+0.85%) ⬆️
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 22, 2017

Coverage Status

Coverage decreased (-0.02%) to 78.158% when pulling 773fedd on chu11:issue998 into 91319ff on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 24, 2017

Maybe a cut and paste error in doc/man3/Makefile/am:

flux_request_encode_raw.3: flux_response_decode.3

the dependency should be on flux_response_encode.3?

chu11 added some commits Apr 21, 2017

doc/man3: Add missing manpages
Add manpages for flux_request_encode(), flux_request_encode_raw(),
flux_response_decode(), and flux_response_decode_raw().

Fixes #998

@chu11 chu11 force-pushed the chu11:issue998 branch from 773fedd to 5b101bd Apr 24, 2017

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 24, 2017

@garlick - doh! Thanks for the catch.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 24, 2017

Coverage Status

Coverage decreased (-0.008%) to 78.174% when pulling 5b101bd on chu11:issue998 into 91319ff on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 24, 2017

Hmmm, travis failure with #993 FAIL: t0015-cron.t 10 - cron entry exec failure is recorded. Obviously didn't directly tickle this since this is just manpage updates. Trying again.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Apr 24, 2017

Sorry about that, I updated the issue, it is most likely that the sleep 0.1 isn't quite long enough on rare occasions...

@garlick garlick merged commit 4937852 into flux-framework:master Apr 24, 2017

3 of 4 checks passed

codecov/project 77.92% (-0.01%) compared to 91319ff
Details
codecov/patch Coverage not affected when comparing 91319ff...5b101bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 78.174%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.