Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few miscellaneous KVS cleanups #1057

Merged
merged 3 commits into from May 11, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented May 11, 2017

Just a few tiny cleanups I found while doing some other work. All trivial changes.

chu11 added some commits May 2, 2017

modules/kvs: Do not pass unnecessary variable
Do not pass in unnecessary variable to function call.  The function
call is only used to test a condition and the value returned from
an in/out parameter is not needed.
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 11, 2017

Coverage Status

Coverage remained the same at 77.935% when pulling 1ea6e9e on chu11:misccleanup5 into 095a509 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #1057 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files         148      148           
  Lines       25752    25752           
=======================================
  Hits        20004    20004           
  Misses       5748     5748
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 80.97% <100%> (+0.24%) ⬆️
src/common/libflux/response.c 83.76% <0%> (-1.71%) ⬇️
src/common/libflux/message.c 80.95% <0%> (-0.37%) ⬇️
src/modules/connector-local/local.c 70.49% <0%> (+0.2%) ⬆️
src/common/libflux/rpc.c 91.2% <0%> (+0.73%) ⬆️

@garlick garlick merged commit 79e983a into flux-framework:master May 11, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.67%)
Details
codecov/project 77.67% (+0%) compared to 095a509
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.935%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.